FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour


Description:
go-tour: supply alternate GOPATH when building locally

Fixes issue 5246.

Please review this at https://codereview.appspot.com/8567043/

Affected files:
M gotour/local.go


Index: gotour/local.go
===================================================================
--- a/gotour/local.go
+++ b/gotour/local.go
@@ -155,6 +155,10 @@
Errors string `json:"compile_errors"`
}

+func init() {
+ socket.Environ = environ
+}
+
// environ returns an execution environment containing only GO* variables
// and replacing GOPATH with the value of the global var gopath.
func environ() (env []string) {


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • David Symonds at Apr 9, 2013 at 10:19 am
    LGTM

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Adg at Apr 9, 2013 at 10:25 am
    *** Submitted as
    https://code.google.com/p/go-tour/source/detail?r=14d4acdb5845 ***

    go-tour: supply alternate GOPATH when building locally

    Fixes issue 5246.

    R=golang-dev, dsymonds
    CC=golang-dev
    https://codereview.appspot.com/8567043


    https://codereview.appspot.com/8567043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedApr 9, '13 at 10:17a
activeApr 9, '13 at 10:25a
posts3
users2
websitegolang.org

2 users in discussion

Adg: 2 posts David Symonds: 1 post

People

Translate

site design / logo © 2022 Grokbase