FAQ

On 2013/03/22 16:30:40, r wrote:
*** Submitted as
https://code.google.com/p/go/source/detail?r=7f837c455456 ***
image/gif: reject a GIF image if frame bounds larger than image bounds
TestBounds doesn't like multiple -cpu values:

=== RUN TestDecode
--- PASS: TestDecode (0.00 seconds)
=== RUN TestBounds
--- PASS: TestBounds (0.00 seconds)
=== RUN TestDecode-2
--- PASS: TestDecode-2 (0.00 seconds)
=== RUN TestBounds-2
--- FAIL: TestBounds-2 (0.00 seconds)
reader_test.go:112: got gif: frame bounds larger than image bounds, want
gif: too much image data
=== RUN TestDecode-4
--- PASS: TestDecode-4 (0.00 seconds)
=== RUN TestBounds-4
--- FAIL: TestBounds-4 (0.00 seconds)
reader_test.go:112: got gif: frame bounds larger than image bounds, want
gif: too much image data
FAIL
FAIL image/gif 0.029s

https://codereview.appspot.com/7602045/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Jeff R. Allen at Mar 25, 2013 at 7:32 am
    What is this "multi threading" you're talking about and what's the big deal
    about it anyway? :)

    Will post a CL tomorrow to fix this, sorry. (It should be as simple as
    moving testGIF into local scope.)

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Fullung at Mar 25, 2013 at 7:38 am
    Hello
    On 2013/03/25 07:32:38, jra wrote:
    What is this "multi threading" you're talking about and what's the big deal
    about it anyway? :)
    At some point in the past there was a discussion with Dmitry which lead
    to me the conclusion that I should include the following in my stress
    tests:

    go test -v -short -cpu 1,2,4 std
    go test -v -cpu 1,2,4 std

    These tend to turn up tests that weren't written to run more than once
    in the same process.

    I think there's value in this, but given that two separate packages
    tripped over this in the last few days, it seems like we need to do
    something to help people realise sooner when they break this test mode.
    That's probably a discussion for a separate thread.

    Cheers

    Albert

    https://codereview.appspot.com/7602045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave Cheney at Mar 25, 2013 at 9:23 am
    https://codereview.appspot.com/7808045

    PTAL.
    On Mon, Mar 25, 2013 at 6:38 PM, wrote:
    Hello

    On 2013/03/25 07:32:38, jra wrote:

    What is this "multi threading" you're talking about and what's the big deal
    about it anyway? :)

    At some point in the past there was a discussion with Dmitry which lead
    to me the conclusion that I should include the following in my stress
    tests:

    go test -v -short -cpu 1,2,4 std
    go test -v -cpu 1,2,4 std

    These tend to turn up tests that weren't written to run more than once
    in the same process.

    I think there's value in this, but given that two separate packages
    tripped over this in the last few days, it seems like we need to do
    something to help people realise sooner when they break this test mode.
    That's probably a discussion for a separate thread.

    Cheers

    Albert

    https://codereview.appspot.com/7602045/

    --

    ---You received this message because you are subscribed to the Google Groups
    "golang-dev" group.

    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave Cheney at Mar 25, 2013 at 9:30 am
    Albert,

    I would be grateful if you would lead off the discussion about testing
    with multiple cpu values. I see this as a question of test repeatably,
    ie, go test -cpu=1,1,1. I'm sure we have some gaps in the std library.

    Cheers

    Dave
    On Mon, Mar 25, 2013 at 6:38 PM, wrote:
    Hello

    On 2013/03/25 07:32:38, jra wrote:

    What is this "multi threading" you're talking about and what's the big deal
    about it anyway? :)

    At some point in the past there was a discussion with Dmitry which lead
    to me the conclusion that I should include the following in my stress
    tests:

    go test -v -short -cpu 1,2,4 std
    go test -v -cpu 1,2,4 std

    These tend to turn up tests that weren't written to run more than once
    in the same process.

    I think there's value in this, but given that two separate packages
    tripped over this in the last few days, it seems like we need to do
    something to help people realise sooner when they break this test mode.
    That's probably a discussion for a separate thread.

    Cheers

    Albert

    https://codereview.appspot.com/7602045/

    --

    ---You received this message because you are subscribed to the Google Groups
    "golang-dev" group.

    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 25, '13 at 7:25a
activeMar 25, '13 at 9:30a
posts5
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase