FAQ
Hello nigeltao@golang.org, jra@nella.org, r@golang.org (cc:
bradfitz@golang.org, golang-dev@googlegroups.com),

Please take another look.


https://codereview.appspot.com/7602045/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • R at Mar 22, 2013 at 3:28 pm
    https://codereview.appspot.com/7602045/diff/45001/src/pkg/image/gif/reader_test.go
    File src/pkg/image/gif/reader_test.go (right):

    https://codereview.appspot.com/7602045/diff/45001/src/pkg/image/gif/reader_test.go#newcode88
    src/pkg/image/gif/reader_test.go:88: // theGIF is a simple GIF that we
    can modify to test different scenarios.
    the 'the' is not idiomatic in standard tests. how about 'testGIF'?

    https://codereview.appspot.com/7602045/diff/45001/src/pkg/image/gif/reader_test.go#newcode107
    src/pkg/image/gif/reader_test.go:107: var estr string
    s/estr/got/

    https://codereview.appspot.com/7602045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Jeff Allen at Mar 22, 2013 at 3:31 pm
    Hello nigeltao@golang.org, jra@nella.org, r@golang.org (cc:
    bradfitz@golang.org, golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/7602045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R at Mar 22, 2013 at 4:28 pm
    LGTM
    thanks


    https://codereview.appspot.com/7602045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R at Mar 22, 2013 at 4:37 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=7f837c455456 ***

    image/gif: reject a GIF image if frame bounds larger than image bounds

    The GIF89a spec says: "Each image must fit within the
    boundaries of the Logical Screen, as defined in the
    Logical Screen Descriptor." Also, do not accept
    GIFs which have too much data for the image size.

    R=nigeltao, jra, r
    CC=bradfitz, golang-dev
    https://codereview.appspot.com/7602045

    Committer: Rob Pike <r@golang.org>


    https://codereview.appspot.com/7602045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 22, '13 at 3:04p
activeMar 22, '13 at 4:37p
posts5
users2
websitegolang.org

2 users in discussion

R: 3 posts Jeff Allen: 2 posts

People

Translate

site design / logo © 2022 Grokbase