FAQ
Old CL, but I found this via the Go 1.1 release notes. I am concerned
about the API change here, even though it does not manifest in a Go
signature change. Is there something wrong with requiring people to
write -1 when indexing into the symbol list? I am concerned that people
who have already written the -1 in Go 1.0 will now have to take it out
in Go 1.1. This seems to me a violation of the Go 1 compatibility
promise.


https://codereview.appspot.com/6848044/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Michael Jones at Mar 19, 2013 at 11:44 pm
    why not replicate the first element and give an address of array[1]

    On Tue, Mar 19, 2013 at 4:28 PM, wrote:

    Old CL, but I found this via the Go 1.1 release notes. I am concerned
    about the API change here, even though it does not manifest in a Go
    signature change. Is there something wrong with requiring people to
    write -1 when indexing into the symbol list? I am concerned that people
    who have already written the -1 in Go 1.0 will now have to take it out
    in Go 1.1. This seems to me a violation of the Go 1 compatibility
    promise.


    https://codereview.appspot.**com/6848044/<https://codereview.appspot.com/6848044/>

    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
    .
    For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
    .


    --
    Michael T. Jones | Chief Technology Advocate | mtj@google.com | +1
    650-335-5765

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Jsing at Mar 20, 2013 at 3:21 am

    On 2013/03/19 23:28:25, rsc wrote:
    Old CL, but I found this via the Go 1.1 release notes. I am concerned about the
    API change here, even though it does not manifest in a Go signature
    change. Is
    there something wrong with requiring people to write -1 when indexing into the
    symbol list? I am concerned that people who have already written the -1 in Go
    1.0 will now have to take it out in Go 1.1. This seems to me a
    violation of the
    Go 1 compatibility promise.
    As discussed at the time of the CL, we already expose the ELF and DWARF
    data, some of which specify indexes into the symbol table. All of these
    indexes are now incorrect since we've silently dropped a symbol. I agree
    that this changes the behaviour of debug/elf between Go 1.0 and Go 1.1,
    however the counter argument is that previously you had to know that you
    needed to subtract one when indexing into the slice returned by Symbols.
    I do not believe this was documented anywhere, so if people are using
    this code for Go 1.0 they have already read well beyond the
    documentation. Given the amount of time and effort that it took me to
    debug the problem that this was causing (a missing -1 in our own
    standard library), I am strongly in favour of returning the full and
    correct symbol table. Another option would be to add a new function that
    returns all of the symbols, and leave Symbols with the broken Go 1.0
    behaviour.

    https://codereview.appspot.com/6848044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 19, '13 at 11:28p
activeMar 20, '13 at 3:21a
posts3
users3
websitegolang.org

3 users in discussion

Rsc: 1 post Michael Jones: 1 post Jsing: 1 post

People

Translate

site design / logo © 2022 Grokbase