FAQ
Reviewers: dsymonds,

Message:
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
encoding/base32: don't panic when decoding "AAAA==".

Edit encoding/base64's internals and tests to match encoding/base32.

Properly handling line breaks in padding is left for another CL.

Please review this at https://codereview.appspot.com/7693044/

Affected files:
M src/pkg/encoding/base32/base32.go
M src/pkg/encoding/base32/base32_test.go
M src/pkg/encoding/base64/base64.go
M src/pkg/encoding/base64/base64_test.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Dsymonds at Mar 11, 2013 at 5:07 am
    LGTM

    but sit on it for a day so other eyes can check it.


    https://codereview.appspot.com/7693044/diff/5001/src/pkg/encoding/base32/base32_test.go
    File src/pkg/encoding/base32/base32_test.go (right):

    https://codereview.appspot.com/7693044/diff/5001/src/pkg/encoding/base32/base32_test.go#newcode175
    src/pkg/encoding/base32/base32_test.go:175: } else {
    insert a continue in the previous branch, and drop this else.

    https://codereview.appspot.com/7693044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Nigel Tao at Mar 11, 2013 at 5:14 am

    On Mon, Mar 11, 2013 at 3:59 PM, wrote:
    encoding/base32: don't panic when decoding "AAAA==".
    I forgot to mention that this is the base32 equivalent of base64's
    https://codereview.appspot.com/5975052/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 11, '13 at 4:59a
activeMar 11, '13 at 5:14a
posts3
users2
websitegolang.org

2 users in discussion

Nigel Tao: 2 posts Dsymonds: 1 post

People

Translate

site design / logo © 2022 Grokbase