FAQ
Reviewers: agl,

Message:
Hello agl@chromium.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
crypto: implemented hash based key derivation (HKDF).

Detailed description in RFC 5869.

Please review this at https://codereview.appspot.com/7592043/

Affected files:
A src/pkg/crypto/hkdf/hkdf.go
A src/pkg/crypto/hkdf/hkdf_test.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Anthony Martin at Mar 7, 2013 at 8:34 pm
    This should probably be in the go.crypto subrepository.

    Anthony

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Minux Ma at Mar 7, 2013 at 8:34 pm
    please move this to go.crypto sub-repository.
    (go get code.google.com/p/go.crypto, and move hkdf to
    $GOPATH/src/code.google.com/p/go.crypto and mail
    a new CL)

    also note: as it's close to Go 1.1 release, we're now in
    Go 1.1 freezing period, please wait until after Go 1.1
    is released. for details, see http://golang.org/s/go11freeze

    Thank you!


    https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go
    File src/pkg/crypto/hkdf/hkdf.go (right):

    https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go#newcode5
    src/pkg/crypto/hkdf/hkdf.go:5: // Package hkdf implements the HMAC-based
    Extract-and-Expand Key Derivation
    blank lines below make this not a package document.
    please put // on blank lines below.

    https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go#newcode15
    src/pkg/crypto/hkdf/hkdf.go:15:
    and delete this blank line.

    https://codereview.appspot.com/7592043/diff/5001/src/pkg/crypto/hkdf/hkdf.go#newcode63
    src/pkg/crypto/hkdf/hkdf.go:63: // New returns a new HKDF using the
    given hash.Hash type, the mater keying material
    s/mater/master/
    s/given hash.Hash type/given hash.Hash constructor/

    https://codereview.appspot.com/7592043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Peterke at Mar 7, 2013 at 10:52 pm
    Sorry about the wrong (sub)repo. Wasn't aware that they are separated
    (even though there was a reference by agl to it). I'll update and open a
    new change-list.

    Btw, when is Go 1.1 planned to be released? I.e. when should I submit
    the new review request?

    Thanks!

    https://codereview.appspot.com/7592043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 7, '13 at 8:18p
activeMar 7, '13 at 10:52p
posts4
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase