FAQ

On 2013/03/01 19:12:38, minux wrote:
On Fri, Mar 1, 2013 at 11:37 PM, wrote:
On 2013/03/01 15:34:51, Ewan Chou wrote:
On 2013/03/01 14:26:26, rsc wrote:
If you write string(utf8.RuneError) you'll get rid of the
remaining
allocation too.
This is my first time to make a CL, and I tried to change it again
by
ran "hg
update 7458043", but it only changes description, no delta is
added.
it was "hg change 7458043" actually, sorry
use "hg upload 7458043" to upload new patchset.
btw, please include benchmark results in the description, the
misc/benchcmp
script will help generate delta between benchmark results.
go test -bench=. strings > old.txt
# edit your changes
go test -bench=. strings > new.txt
$GOROOT/misc/benchcmp old.txt new.txt
and paste the output into the CL description.
benchmark result updated, but "explode" doesn't has benchmark function
in "strings_test.go" so run "go test -bench=. strings" doesn't show any
difference.

https://codereview.appspot.com/7458043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Dave Cheney at Mar 2, 2013 at 2:37 am
    Oh, could you please add some benchmarks as part of this CL?

    Sent from my iPad
    On 02/03/2013, at 1:33 PM, coocood@gmail.com wrote:
    On 2013/03/01 19:12:38, minux wrote:
    On Fri, Mar 1, 2013 at 11:37 PM, wrote:
    On 2013/03/01 15:34:51, Ewan Chou wrote:
    On 2013/03/01 14:26:26, rsc wrote:
    If you write string(utf8.RuneError) you'll get rid of the
    remaining
    allocation too.
    This is my first time to make a CL, and I tried to change it again
    by
    ran "hg
    update 7458043", but it only changes description, no delta is
    added.
    it was "hg change 7458043" actually, sorry
    use "hg upload 7458043" to upload new patchset.
    btw, please include benchmark results in the description, the
    misc/benchcmp
    script will help generate delta between benchmark results.
    go test -bench=. strings > old.txt
    # edit your changes
    go test -bench=. strings > new.txt
    $GOROOT/misc/benchcmp old.txt new.txt
    and paste the output into the CL description.
    benchmark result updated, but "explode" doesn't has benchmark function
    in "strings_test.go" so run "go test -bench=. strings" doesn't show any
    difference.

    https://codereview.appspot.com/7458043/
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Coocood at Mar 2, 2013 at 3:08 am
    Added three benchmark functions for Split method.
    On 2013/03/02 02:37:22, dfc wrote:
    Oh, could you please add some benchmarks as part of this CL?
    Sent from my iPad



    https://codereview.appspot.com/7458043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave at Mar 2, 2013 at 3:14 am
    Can you please do this to report the benchmark delta.

    1. go test -bench=Split > old.txt
    // apply your change
    2. go test -bench=Split > new.txt
    3. $GOROOT/misc/benchcmp {old,new}.txt

    Do this a few times to ensure the results are stable, then attach the
    output to the issue description.

    https://codereview.appspot.com/7458043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Coocood at Mar 2, 2013 at 4:17 am

    On 2013/03/02 03:14:29, dfc wrote:
    Can you please do this to report the benchmark delta.
    1. go test -bench=Split > old.txt
    // apply your change
    2. go test -bench=Split > new.txt
    3. $GOROOT/misc/benchcmp {old,new}.txt
    Do this a few times to ensure the results are stable, then attach the output to
    the issue description.
    It turns out that new explode method makes BenchmarkSplit2 about 5%
    slower, it's unreasonable, as explode didn't even get called.

    https://codereview.appspot.com/7458043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Coocood at Mar 2, 2013 at 6:36 am

    On 2013/03/02 04:17:08, Ewan Chou wrote:
    On 2013/03/02 03:14:29, dfc wrote:
    Can you please do this to report the benchmark delta.

    1. go test -bench=Split > old.txt
    // apply your change
    2. go test -bench=Split > new.txt
    3. $GOROOT/misc/benchcmp {old,new}.txt

    Do this a few times to ensure the results are stable, then attach
    the output
    to
    the issue description.
    It turns out that new explode method makes BenchmarkSplit2 about 5%
    slower, it's
    unreasonable, as explode didn't even get called.
    This happens just randomly, after I removed "if n == 0 {return nil}"
    Every Split benchmark get faster.

    https://codereview.appspot.com/7458043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave Cheney at Mar 2, 2013 at 6:51 am
    What OS are you benchmarking on ?
    On 02/03/2013, at 17:36, coocood@gmail.com wrote:
    On 2013/03/02 04:17:08, Ewan Chou wrote:
    On 2013/03/02 03:14:29, dfc wrote:
    Can you please do this to report the benchmark delta.

    1. go test -bench=Split > old.txt
    // apply your change
    2. go test -bench=Split > new.txt
    3. $GOROOT/misc/benchcmp {old,new}.txt

    Do this a few times to ensure the results are stable, then attach
    the output
    to
    the issue description.
    It turns out that new explode method makes BenchmarkSplit2 about 5%
    slower, it's
    unreasonable, as explode didn't even get called.
    This happens just randomly, after I removed "if n == 0 {return nil}"
    Every Split benchmark get faster.

    https://codereview.appspot.com/7458043/
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Coocood at Mar 2, 2013 at 6:53 am

    On 2013/03/02 06:51:20, dfc wrote:
    What OS are you benchmarking on ?
    Windows 7 64bit GOARCH amd64


    https://codereview.appspot.com/7458043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave Cheney at Mar 2, 2013 at 6:56 am
    Fair enough, using pprof on windows is quite hard, I was going to say do a profile and see why the breakdown is.
    On 02/03/2013, at 17:53, coocood@gmail.com wrote:
    On 2013/03/02 06:51:20, dfc wrote:
    What OS are you benchmarking on ?
    Windows 7 64bit GOARCH amd64


    https://codereview.appspot.com/7458043/
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMar 2, '13 at 2:33a
activeMar 2, '13 at 6:56a
posts9
users2
websitegolang.org

2 users in discussion

Coocood: 5 posts Dave Cheney: 4 posts

People

Translate

site design / logo © 2022 Grokbase