FAQ
LGTM

My only concern here is that this ads yet another flag - thus increasing
the number of different operation modes that each godoc change must be
tested in. Presumably showing the examples always is blowing up the
output too much in general?

That said, the added code is very self-contained (even the flag use), so
maybe we should just see how it goes, as long as we keep in mind that
it's harder to take a flag away once people got used to it...

Andrew, please feel free to submit if you're happy.
Thanks.
- gri



https://codereview.appspot.com/7356043/diff/20001/src/cmd/godoc/godoc.go
File src/cmd/godoc/godoc.go (right):

https://codereview.appspot.com/7356043/diff/20001/src/cmd/godoc/godoc.go#newcode346
src/cmd/godoc/godoc.go:346: if first {
if !first {
buf.Writestring("\n")
}
first = false

is simpler (and likely produces less code)

https://codereview.appspot.com/7356043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedFeb 22, '13 at 6:55a
activeFeb 22, '13 at 6:55a
posts1
users1
websitegolang.org

1 user in discussion

Gri: 1 post

People

Translate

site design / logo © 2022 Grokbase