FAQ
Reviewers: ken2,

Message:
Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/5g, cmd/6g: fix node dump formats

lvd changed the old %N to %+hN and these
never got updated.

Please review this at https://codereview.appspot.com/7391045/

Affected files:
M src/cmd/5g/cgen.c
M src/cmd/6g/cgen.c


Index: src/cmd/5g/cgen.c
===================================================================
--- a/src/cmd/5g/cgen.c
+++ b/src/cmd/5g/cgen.c
@@ -193,7 +193,7 @@
switch(n->op) {
default:
dump("cgen", n);
- fatal("cgen: unknown op %N", n);
+ fatal("cgen: unknown op %+hN", n);
break;

case OREAL:
@@ -598,7 +598,7 @@

switch(n->op) {
default:
- fatal("agen: unknown op %N", n);
+ fatal("agen: unknown op %+hN", n);
break;

case OCALLMETH:
Index: src/cmd/6g/cgen.c
===================================================================
--- a/src/cmd/6g/cgen.c
+++ b/src/cmd/6g/cgen.c
@@ -191,7 +191,7 @@
switch(n->op) {
default:
dump("cgen", n);
- fatal("cgen: unknown op %N", n);
+ fatal("cgen: unknown op %+hN", n);
break;

// these call bgen to get a bool value
@@ -820,7 +820,7 @@

switch(n->op) {
default:
- fatal("agen: unknown op %N", n);
+ fatal("agen: unknown op %+hN", n);
break;

case OCALLMETH:


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Rsc at Feb 21, 2013 at 5:53 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=f6fd55a8c1b8 ***

    cmd/5g, cmd/6g: fix node dump formats

    lvd changed the old %N to %+hN and these
    never got updated.

    R=ken2
    CC=golang-dev
    https://codereview.appspot.com/7391045


    https://codereview.appspot.com/7391045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedFeb 21, '13 at 5:53p
activeFeb 21, '13 at 5:53p
posts2
users1
websitegolang.org

1 user in discussion

Rsc: 2 posts

People

Translate

site design / logo © 2021 Grokbase