FAQ
Hello golang-dev@googlegroups.com (cc: adg@golang.org),

I'd like you to review this change to
https://code.google.com/p/go


https://codereview.appspot.com/7305072/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Donovanhide at Feb 10, 2013 at 5:41 pm
    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go
    File src/pkg/archive/tar/common.go (right):

    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go#newcode75
    src/pkg/archive/tar/common.go:75: mode = os.FileMode(fi.h.Mode) &
    os.ModePerm
    It's a bit obscure, but the mask 1777 allows for the preservation of the
    sticky bit:
    http://en.wikipedia.org/wiki/Sticky_bit
    https://codereview.appspot.com/7203050

    https://codereview.appspot.com/7305072/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Minux Ma at Feb 10, 2013 at 6:22 pm
    tests?


    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go
    File src/pkg/archive/tar/common.go (right):

    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go#newcode75
    src/pkg/archive/tar/common.go:75: mode = os.FileMode(fi.h.Mode) &
    os.ModePerm
    On 2013/02/10 11:14:48, Donovan wrote:
    It's a bit obscure, but the mask 1777 allows for the preservation of
    the sticky
    tar supports setuid and setgid, so perhaps you need 07777.

    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go#newcode98
    src/pkg/archive/tar/common.go:98: case '0', '\x00':
    please use TypeReg, TypeRegA here.

    https://codereview.appspot.com/7305072/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Feb 10, 2013 at 8:39 pm
    Hello golang-dev@googlegroups.com, donovanhide@gmail.com,
    r.eklind.87@gmail.com, minux.ma@gmail.com (cc: adg@golang.org,
    golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/7305072/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Feb 10, 2013 at 8:39 pm

    On 2013/02/10 18:22:17, minux wrote:
    tests?
    I want to include test but don't know yet which way to do it. Should we
    extend the previous test and add more members the the struct so it can
    also test Header.FileInfo or should we create a new struct and duplicate
    some of the data?

    Either way we should probably add at least one more tar testdata file,
    which includes FIFO, socket, device and other special files.


    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go
    File src/pkg/archive/tar/common.go (right):

    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go#newcode75
    src/pkg/archive/tar/common.go:75: mode = os.FileMode(fi.h.Mode) &
    os.ModePerm
    On 2013/02/10 11:14:48, Donovan wrote:
    It's a bit obscure, but the mask 1777 allows for the preservation of
    the
    sticky
    tar supports setuid and setgid, so perhaps you need 07777.
    It now handles sticky bit, setuid and setgid properly. We can't copy
    them directly since Go uses other bits to represent these platform
    independently.


    https://codereview.appspot.com/7305072/diff/7001/src/pkg/archive/tar/common.go#newcode98
    src/pkg/archive/tar/common.go:98: case '0', '\x00':
    please use TypeReg, TypeRegA here.
    The code has been updated to use Type*.

    Did you see my first message?
    https://codereview.appspot.com/7305072/#msg1

    Is there a way to differentiate a hard link from a symbolic link using
    os.FileMode? Is os.ModeSymlink correct for hard links?

    Should we remove nop cases (TypeReg, TypeRegA, TypeCont, TypeXHeader and
    TypeXGlobalHeader)?

    https://codereview.appspot.com/7305072/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedFeb 10, '13 at 3:15a
activeFeb 10, '13 at 8:39p
posts5
users3
websitegolang.org

People

Translate

site design / logo © 2021 Grokbase