FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
crypto/x509: all MS/NS SCG key usage as ServerAuth.

By default, crypto/x509 assumes that users wish to validate
certificates for ServerAuth. However, due to historical reasons,
COMODO's intermediates don't specify ServerAuth as an allowed key
usage.

Rather NSS and CryptoAPI both allow these SGC OIDs to be equivalent to
ServerAuth.

Please review this at https://codereview.appspot.com/7312070/

Affected files:
M src/pkg/crypto/x509/verify.go
M src/pkg/crypto/x509/verify_test.go
M src/pkg/crypto/x509/x509.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Rsc at Feb 9, 2013 at 6:03 pm
    LGTM

    First line of CL desc: s/all/allow/


    https://codereview.appspot.com/7312070/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Agl at Feb 9, 2013 at 6:21 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=12a2a5f062e5 ***

    crypto/x509: allow MS/NS SCG key usage as ServerAuth.

    By default, crypto/x509 assumes that users wish to validate
    certificates for ServerAuth. However, due to historical reasons,
    COMODO's intermediates don't specify ServerAuth as an allowed key
    usage.

    Rather NSS and CryptoAPI both allow these SGC OIDs to be equivalent to
    ServerAuth.

    R=rsc
    CC=golang-dev
    https://codereview.appspot.com/7312070


    https://codereview.appspot.com/7312070/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedFeb 9, '13 at 5:44p
activeFeb 9, '13 at 6:21p
posts3
users2
websitegolang.org

2 users in discussion

Agl: 2 posts Rsc: 1 post

People

Translate

site design / logo © 2022 Grokbase