FAQ
Actually I was thinking that we should avoid relying on testdata/ files
altogether, so that this can be run in the playground sandbox.

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • R Eklind 87 at Jan 31, 2013 at 4:55 am
    Hello golang-dev@googlegroups.com, minux.ma@gmail.com, adg@golang.org
    (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Jan 31, 2013 at 4:55 am
    On 2013/01/29 04:21:48, adg wrote:

    https://codereview.appspot.com/7220048/diff/1002/src/pkg/archive/tar/example_test.go
    File src/pkg/archive/tar/example_test.go (right):

    https://codereview.appspot.com/7220048/diff/1002/src/pkg/archive/tar/example_test.go#newcode11
    src/pkg/archive/tar/example_test.go:11: func ExampleReader() {
    We could make this example self-contained by covering both the reader and the
    writer parts. First write a tar file into a bytes.Buffer and then read it back.
    What do you think?
    Sounds good and sorry for the double commit. Any suggestions of how to
    make it cleaner?

    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Jan 31, 2013 at 4:55 am
    Hello golang-dev@googlegroups.com, minux.ma@gmail.com, adg@golang.org
    (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Minux at Jan 31, 2013 at 8:34 am

    On Thursday, January 31, 2013, Andrew Gerrand wrote:

    Actually I was thinking that we should avoid relying on testdata/ files
    altogether, so that this can be run in the playground sandbox.
    i imagine that when running locally with godoc -play,
    we can start the compiled binary under the directory
    for the current package, so that examples using
    testdat could be run, what do you think?

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Jan 31, 2013 at 4:45 pm
    Hello golang-dev@googlegroups.com, minux.ma@gmail.com, adg@golang.org
    (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Jan 31, 2013 at 4:45 pm

    On 2013/01/31 16:32:05, u wrote:
    Hello mailto:golang-dev@googlegroups.com, mailto:minux.ma@gmail.com,
    mailto:adg@golang.org (cc:
    mailto:golang-dev@googlegroups.com),
    Please take another look.
    I agree that it's nice if this code runs smoothly in the playground. The
    only
    thing missing would be the example usage of tar.FileInfoHeader, which is
    quite
    convenient when handling actual files.

    I've updated the example code. Before the final commit, "hello world"
    could be replaced with something more imaginative.

    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Jan 31, 2013 at 10:57 pm
    The examples are now more consistent with the zip examples.

    The zip example is split into a reader and a writer. The reader uses
    testdata. What is the preferred solution?

    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R Eklind 87 at Jan 31, 2013 at 10:57 pm
    Hello golang-dev@googlegroups.com, minux.ma@gmail.com, adg@golang.org
    (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/7220048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 31, '13 at 4:46a
activeJan 31, '13 at 10:57p
posts9
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase