FAQ
Hi Chressie1,
Sorry I've been so busy, but I haven't gone mia. I'd be happy to have
you merge your changes into this review. I'm generally on #go-nuts if
you have any questions.
On 2013/01/30 13:12:54, chressie1 wrote:
On 2013/01/30 13:04:24, chressie1 wrote:

i think this is very close to be finished. if there's help required,
i'd be
happy to update this CL..
to be clear, i'm thinking about merging
https://codereview.appspot.com/6814084/
into this CL.


https://codereview.appspot.com/6700047/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Chressie at Jan 31, 2013 at 11:24 am

    On 2013/01/31 03:00:18, shanemhansen wrote:
    Hi Chressie1,
    Sorry I've been so busy, but I haven't gone mia. I'd be happy to have you merge
    your changes into this review. I'm generally on #go-nuts if you have any
    questions.
    no worries :)

    unfortunately i cannot update this CL, so i created a merge CL here:

    https://codereview.appspot.com/7229066

    dsymonds, i'd suppose to submit this now as is and to address rsc's
    concern in the other CL?

    thanks,
    chressie

    https://codereview.appspot.com/6700047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • David Symonds at Jan 31, 2013 at 10:56 pm
    I think we should just get Shane's CL finished off (I believe it's
    very close), and add chressie's changes in separately.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Shane Hansen at Feb 6, 2013 at 3:48 am
    Sounds good to me. I'll work on adding support for ustar long names.

    Thanks for your patience.
    On Thu, Jan 31, 2013 at 3:56 PM, David Symonds wrote:

    I think we should just get Shane's CL finished off (I believe it's
    very close), and add chressie's changes in separately.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Christian Himpel at Feb 6, 2013 at 7:18 am
    sorry, i'm afraid, i wasn't clear in the first place. the merge CL
    https://codereview.appspot.com/7229066 is exactly about adding ustar
    long names (i.e. using the 155 chars prefix field) to the current CL.
    feel free to copy'n'paste it, if you want.
    On Wed, Feb 6, 2013 at 4:48 AM, Shane Hansen wrote:
    Sounds good to me. I'll work on adding support for ustar long names.

    Thanks for your patience.
    On Thu, Jan 31, 2013 at 3:56 PM, David Symonds wrote:

    I think we should just get Shane's CL finished off (I believe it's
    very close), and add chressie's changes in separately.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Chressie at Feb 6, 2013 at 7:22 am
    one last thing..


    https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/writer_test.go
    File src/pkg/archive/tar/writer_test.go (right):

    https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/writer_test.go#newcode225
    src/pkg/archive/tar/writer_test.go:225: func aTestPAXHeader(t
    *testing.T) {
    this test is never executed (due to the leading 'a')..

    i noticed that it fails, because of the ambiguity of the "multiple
    acceptable lengths" tests. this should be cleaned up before activating
    the test.

    https://codereview.appspot.com/6700047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Shanemhansen at Feb 6, 2013 at 5:14 pm
    Good find.

    This would be done last night except I switched to an
    OSX system and learned that:
    1) bsd tar uses ' ' (20) to pad octal group names instead of \0 (0)
    2) bsd and gnu tar use different heuristics for where to split the
    filename.

    So it looks like in order to be go tar compatible we need to use gnu tar
    for the test ustar
    file (for \0 padding), which means I have to update the file splitting
    heuristic.

    For a brief mention of \0 and ' ' see:
    http://en.wikipedia.org/wiki/Tar_(computing)#UStar_format

    Should be done soon.
    On 2013/02/06 07:22:17, chressie1 wrote:
    one last thing..

    https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/writer_test.go
    File src/pkg/archive/tar/writer_test.go (right):

    https://codereview.appspot.com/6700047/diff/53007/src/pkg/archive/tar/writer_test.go#newcode225
    src/pkg/archive/tar/writer_test.go:225: func aTestPAXHeader(t
    *testing.T) {
    this test is never executed (due to the leading 'a')..
    i noticed that it fails, because of the ambiguity of the "multiple
    acceptable
    lengths" tests. this should be cleaned up before activating the test.

    https://codereview.appspot.com/6700047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 31, '13 at 3:00a
activeFeb 6, '13 at 5:14p
posts7
users3
websitegolang.org

People

Translate

site design / logo © 2021 Grokbase