FAQ
still in progress but some confirm.


https://codereview.appspot.com/7092050/diff/24002/spdy/spdy_test.go
File spdy/spdy_test.go (right):

https://codereview.appspot.com/7092050/diff/24002/spdy/spdy_test.go#newcode615
spdy/spdy_test.go:615: t.Log("skipping") // TODO: update to work with
SPDY3
On 2013/01/23 02:24:23, mikio wrote:
you can use t.Skipf("skipping: TODO: update to work with SPDY/3")
Is that implemented ?
http://golang.org/pkg/testing/

https://codereview.appspot.com/7092050/diff/24002/spdy/types.go
File spdy/types.go (right):

https://codereview.appspot.com/7092050/diff/24002/spdy/types.go#newcode82
spdy/types.go:82: // Note, only 3 highest bits currently used
No, users dosen't need to care about that.
this notes says about implementation.
so, Should I drop this Notes ?
On 2013/01/23 02:24:23, mikio wrote:
looks like this comment is wrong as an API description.
or should we, I mean API users, set the Priority field of
SynStreamFrame to pri<<5 before WriteFrame?

https://codereview.appspot.com/7092050/

--

Search Discussions

  • Mikio Hara at Jan 25, 2013 at 4:15 am

    On Fri, Jan 25, 2013 at 12:57 PM, wrote:

    you can use t.Skipf("skipping: TODO: update to work with SPDY/3")
    Is that implemented ?
    submitted to tip yesterday.
    but I think you can fix that test for spdy/3, so please do.
    spdy/types.go:82: // Note, only 3 highest bits currently used
    No, users dosen't need to care about that.
    this notes says about implementation.
    so, Should I drop this Notes ?
    yup.

    also I'd recommend to add a simple comment to each exposed field which
    seems vague.

    e.g.,

    // SynStreamFrame is the unpacked, in-memory representation of a SYN_STREAM
    // frame.
    type SynStreamFrame struct {
    CFHeader ControlFrameHeader
    StreamId uint32 // stream identifier
    AssociatedToStreamId uint32 // stream identifer for a stream
    which this stream is associated to
    Priority uint8 // 3-bit priority
    Slot uint8 // index in the server's credential vector of
    the client certificate
    Headers http.Header
    }

    --
  • Mikioh Mikioh at Jan 25, 2013 at 4:28 am

    just realized there's no client/server test cases so far.
    do you plan to implement those tests in following CLs?
    never mind, someone will add it someday.


    https://codereview.appspot.com/7092050/diff/24002/spdy/types.go
    File spdy/types.go (right):

    https://codereview.appspot.com/7092050/diff/24002/spdy/types.go#newcode100
    spdy/types.go:100: _ RstStreamStatus = iota
    ProtocolError RstStreamStatus = iota +1

    godoc doesn't display unexposed things.

    https://codereview.appspot.com/7092050/diff/24002/spdy/types.go#newcode134
    spdy/types.go:134: _ SettingsId = iota
    ditto

    https://codereview.appspot.com/7092050/

    --

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 25, '13 at 3:57a
activeJan 25, '13 at 4:28a
posts3
users2
websitegolang.org

People

Translate

site design / logo © 2021 Grokbase