FAQ
https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go
File src/pkg/net/unix_test.go (right):

https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go#newcode18
src/pkg/net/unix_test.go:18: // use ioutil.TempFile to get a name that
is unique
On 2013/01/19 14:10:21, mikio wrote:
// testUnixAddr returns a unique pathname that ... blah blah.
Done.

https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go#newcode19
src/pkg/net/unix_test.go:19: func genAddr() string {
On 2013/01/19 14:10:21, mikio wrote:
maybe testUnixAddr
Done.

https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go#newcode24
src/pkg/net/unix_test.go:24: f.Close()
On 2013/01/19 14:10:21, mikio wrote:
seems wrong f.Close then f.Name
Done.

https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go#newcode44
src/pkg/net/unix_test.go:44:
On 2013/01/19 14:10:21, mikio wrote:
sorry, i forgot to add a channel that avoids ECONNRESET (which rarely happens)
on BSDs.
off := make(chan bool)
data := ...
go func() {
defer func() { off<-true }()
:
}()
<-off
c.SetReadDeadline()
Done.

https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go#newcode81
src/pkg/net/unix_test.go:81: defer os.Remove(addr)
On 2013/01/19 14:10:21, mikio wrote:
delete
Done.

https://codereview.appspot.com/7058062/diff/21001/src/pkg/net/unix_test.go#newcode95
src/pkg/net/unix_test.go:95: go func() {
On 2013/01/19 14:10:21, mikio wrote:
sorry, pls add a channel (same as above)
Done.

https://codereview.appspot.com/7058062/

Search Discussions

  • Mikioh Mikioh at Jan 23, 2013 at 4:18 pm
    https://codereview.appspot.com/7058062/diff/27001/src/pkg/net/unix_test.go
    File src/pkg/net/unix_test.go (right):

    https://codereview.appspot.com/7058062/diff/27001/src/pkg/net/unix_test.go#newcode72
    src/pkg/net/unix_test.go:72: t.Errorf("neighbor address is %v", from)
    hm, on freebsd it returns empty sockaddr.
    jeff, what about on linux?

    go test -v -run=TestReadUnixgramWithUnnamedSocket
    === RUN TestReadUnixgramWithUnnamedSocket-2
    --- FAIL: TestReadUnixgramWithUnnamedSocket-2 (0.00 seconds)
    unix_test.go:71: neighbor address is &net.UnixAddr{Name:"",
    Net:"unixgram"}
    FAIL

    https://codereview.appspot.com/7058062/diff/27001/src/pkg/net/unix_test.go#newcode116
    src/pkg/net/unix_test.go:116: if _, peer, err = c.ReadFrom(nil); err !=
    nil {
    perhaps s/peer/from/ might be consistent.

    _, from, err := c.ReadFrom(nil)
    if err != nil {

    https://codereview.appspot.com/7058062/diff/27001/src/pkg/net/unix_test.go#newcode121
    src/pkg/net/unix_test.go:121: t.Errorf("peer adddress is %v", peer)
    go test -v -run=TestReadUnixgramWithZeroBytesBuffer
    === RUN TestReadUnixgramWithZeroBytesBuffer-2
    --- FAIL: TestReadUnixgramWithZeroBytesBuffer-2 (0.00 seconds)
    unix_test.go:120: neighbor adddress is &net.UnixAddr{Name:"",
    Net:"unixgram"}
    FAIL

    https://codereview.appspot.com/7058062/
  • Mikio Hara at Jan 23, 2013 at 11:57 pm

    On Thu, Jan 24, 2013 at 1:18 AM, wrote:

    hm, on freebsd it returns empty sockaddr.
    jeff, what about on linux?

    go test -v -run=TestReadUnixgramWithUnnamedSocket
    === RUN TestReadUnixgramWithUnnamedSocket-2
    --- FAIL: TestReadUnixgramWithUnnamedSocket-2 (0.00 seconds)
    unix_test.go:71: neighbor address is &net.UnixAddr{Name:"",
    Net:"unixgram"}
    FAIL
    ouch,

    === RUN TestReadUnixgramWithUnnamedSocket-2
    --- PASS: TestReadUnixgramWithUnnamedSocket-2 (0.00 seconds)
    unix_test.go:74: neighbor address is <nil>
    PASS

    didn't know that such differences, hm.
  • Mikioh Mikioh at Jan 24, 2013 at 2:16 am
    FYI


    https://codereview.appspot.com/7058062/diff/27001/src/pkg/net/unix_test.go
    File src/pkg/net/unix_test.go (right):

    https://codereview.appspot.com/7058062/diff/27001/src/pkg/net/unix_test.go#newcode72
    src/pkg/net/unix_test.go:72: t.Errorf("neighbor address is %v", from)
    okay, just confirmed that your tests light green on freebsd with
    https://codereview.appspot.com/7204050/

    https://codereview.appspot.com/7058062/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 23, '13 at 3:18p
activeJan 24, '13 at 2:16a
posts4
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 3 posts Jeff Allen: 1 post

People

Translate

site design / logo © 2022 Grokbase