FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
cmd/api: sort features

Please review this at https://codereview.appspot.com/7141062/

Affected files:
M src/cmd/api/goapi.go


Index: src/cmd/api/goapi.go
===================================================================
--- a/src/cmd/api/goapi.go
+++ b/src/cmd/api/goapi.go
@@ -181,6 +181,7 @@
defer bw.Flush()

if *checkFile == "" {
+ sort.Strings(features)
for _, f := range features {
fmt.Fprintf(bw, "%s\n", f)
}

Search Discussions

  • Minux at Jan 19, 2013 at 1:04 pm
    LGTM. However I don't know why we haven't done this already?
    Brad?
  • Bradfitz at Jan 19, 2013 at 4:40 pm
    LGTM

    I think like that mode (rarely used) regressed in the most recent big
    refactor.

    Thanks!


    https://codereview.appspot.com/7141062/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 19, '13 at 8:26a
activeJan 19, '13 at 4:40p
posts3
users3
websitegolang.org

3 users in discussion

Bradfitz: 1 post Minux: 1 post Ality: 1 post

People

Translate

site design / logo © 2021 Grokbase