FAQ
Minor comments.


https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/doc.go
File src/pkg/exp/ssa/doc.go (right):

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/doc.go#newcode1
src/pkg/exp/ssa/doc.go:1: // exp/ssa: SSA representation of Go programs
// Package ssa ...

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go
File src/pkg/exp/ssa/ssa.go (right):

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode36
src/pkg/exp/ssa/ssa.go:36: type Builder interface {
I don't understand why this is an interface and not a struct. You may
also want to consider a name like Program.

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode89
src/pkg/exp/ssa/ssa.go:89: // Package represents a single analyzed
package, containing Members
s/represents/is/

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode105
src/pkg/exp/ssa/ssa.go:105: // Member represents a member of a package,
implemented by *Literal,
s/represents/is/

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode114
src/pkg/exp/ssa/ssa.go:114: // An Id identifies the name of a field of a
struct type, or the name
ID is more common.

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode132
src/pkg/exp/ssa/ssa.go:132: // A method set contains all the methods
whose receiver is either T or
// A MethodSet

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode213
src/pkg/exp/ssa/ssa.go:213: type Instr interface {
Instruction?

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode270
src/pkg/exp/ssa/ssa.go:270: Signature *types.Signature
In the types below you use Type_, is a Signature significantly
different?

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode387
src/pkg/exp/ssa/ssa.go:387: // A named Value holding the address of a
var defined inside a package
// A Global is a named Value

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode787
src/pkg/exp/ssa/ssa.go:787: // Helper for Select.
// SelectState ...

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode1034
src/pkg/exp/ssa/ssa.go:1034: // Register is a mix-in embedded by all SSA
values that are also
Odd to see these described as mix-ins.

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode1046
src/pkg/exp/ssa/ssa.go:1046: Num int // "name" of virtual
register, e.g. "t0". Not guaranteed unique.
If Num cannot safely be used to identify registers, why expose it? Isn't
Name good enough for debugging?

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode1130
src/pkg/exp/ssa/ssa.go:1130: // Returns the package-level function of
the specified name, or nil
// Func returns

https://codereview.appspot.com/7071058/diff/16001/src/pkg/exp/ssa/ssa.go#newcode1137
src/pkg/exp/ssa/ssa.go:1137: // Returns the package-level variable of
the specified name, or nil
// Var returns

https://codereview.appspot.com/7071058/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 17, '13 at 5:11p
activeJan 17, '13 at 9:41p
posts5
users3
websitegolang.org

3 users in discussion

Adonovan: 3 posts Crawshaw: 1 post Bradfitz: 1 post

People

Translate

site design / logo © 2021 Grokbase