[golang-dev] Re: code review 6964043: net/http: buffer before chunking (issue 6964043)

Brad Fitzpatrick

at Jan 15, 2013 at 1:02 am

This CL changed nothing about concurrency.

It did, however, change chunking. But the tests were adjusted.

Is this a sporadic failure? How to reproduce? I have machines with over
10 cores.

On Mon, Jan 14, 2013 at 12:30 AM, wrote:

Howdy

There seems to be something wrong according to the torture box:

FAIL: TestServerBufferedChunking-10 at serve_test.go:1165

response didn't end with a single 3 byte 'xyz' chunk; got: "HTTP/1.1 200
OK\r\nContent-Type: text/plain; charset=utf-8\r\nDate: Mon, 14 Jan 2013
08:24:10 GMT\r\nTransfer-Encoding: chunked\r\n\r\n"

Looks a bit like this stuff from a while ago, but maybe that's just a
coincidence.

http://code.google.com/p/go/**issues/detail?id=4021<http://code.google.com/p/go/issues/detail?id=4021>

Cheers

Albert

https://codereview.appspot.**com/6964043/<https://codereview.appspot.com/6964043/>

reply | permalink

Albert Strasheim

at Jan 15, 2013 at 11:16 am

⇧

Hello

On Tue, Jan 15, 2013 at 3:02 AM, Brad Fitzpatrick wrote:
This CL changed nothing about concurrency.
It did, however, change chunking. But the tests were adjusted.
Is this a sporadic failure? How to reproduce? I have machines with over 10
cores.

Xeon E5-2670 0 @ 2.60GHz, performance governor, F16 64-bit kernel 3.3.8.

Test always passes with GOMAXPROCS=1 and fails about 80% of the time
with GOMAXPROCS=2 or greater.

Here's a few runs:

$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:27
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:40
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:41
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS

Regards

Albert

reply | permalink

Dave Cheney

at Jan 15, 2013 at 10:49 am

⇧

I know it is a big ask, but it would be a very useful data point for me if you were able to test this under another Linux distro on this hardware. It would be sufficient to do this from a live cd using a prebuilt binary from go test -c.

Is that an option ?

On 15/01/2013, at 20:16, Albert Strasheim wrote:

Hello

On Tue, Jan 15, 2013 at 3:02 AM, Brad Fitzpatrick wrote:
This CL changed nothing about concurrency.
It did, however, change chunking. But the tests were adjusted.
Is this a sporadic failure? How to reproduce? I have machines with over 10
cores.

Xeon E5-2670 0 @ 2.60GHz, performance governor, F16 64-bit kernel 3.3.8.

Test always passes with GOMAXPROCS=1 and fails about 80% of the time
with GOMAXPROCS=2 or greater.

Here's a few runs:

$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:27
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:40
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:41
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS

Regards

Albert

reply | permalink

Albert Strasheim

at Jan 15, 2013 at 9:36 am

⇧

Hello

On Tue, Jan 15, 2013 at 11:21 AM, Dave Cheney wrote:
I know it is a big ask, but it would be a very useful data point for me if you were able to test this under another Linux distro on this hardware. It would be sufficient to do this from a live cd using a prebuilt binary from go test -c.
Is that an option ?

This Xeon is in use by multiple people, so that's a bit tricky.

I can also reproduce this on F17 on a i7-3720QM running
3.6.3-1.fc17.x86_64. I'll fire up an Ubuntu live CD to see what I see.

Cheers

Albert

reply | permalink

Dave Cheney

at Jan 15, 2013 at 9:42 am

⇧

Thanks, that would be a very useful datapoint.

On Tue, Jan 15, 2013 at 8:36 PM, Albert Strasheim wrote:
Hello

On Tue, Jan 15, 2013 at 11:21 AM, Dave Cheney wrote:
I know it is a big ask, but it would be a very useful data point for me if you were able to test this under another Linux distro on this hardware. It would be sufficient to do this from a live cd using a prebuilt binary from go test -c.
Is that an option ?

This Xeon is in use by multiple people, so that's a bit tricky.

I can also reproduce this on F17 on a i7-3720QM running
3.6.3-1.fc17.x86_64. I'll fire up an Ubuntu live CD to see what I see.

Cheers

Albert

reply | permalink

Brad Fitzpatrick

at Jan 15, 2013 at 3:14 pm

⇧

Reproduced on my laptop with GOMAXPROCS=4.

Fix is https://codereview.appspot.com/7109043

On Tue, Jan 15, 2013 at 1:16 AM, Albert Strasheim wrote:

Hello

On Tue, Jan 15, 2013 at 3:02 AM, Brad Fitzpatrick wrote:
This CL changed nothing about concurrency.
It did, however, change chunking. But the tests were adjusted.
Is this a sporadic failure? How to reproduce? I have machines with over 10
cores.

Xeon E5-2670 0 @ 2.60GHz, performance governor, F16 64-bit kernel 3.3.8.

Test always passes with GOMAXPROCS=1 and fails about 80% of the time
with GOMAXPROCS=2 or greater.

Here's a few runs:

$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:27
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:40
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:41
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS

Regards

Albert

reply | permalink

Dave Cheney

at Jan 15, 2013 at 8:03 pm

⇧

Great catch Brad!

Albert, thank you for being so persistent with this issue. I'm sorry
that I thought this was some weird Fedora kernel issue. At least for
every failure we find and fix we gain more confidence that the next
failure reported _is_ real.

On Wed, Jan 16, 2013 at 2:06 AM, Brad Fitzpatrick wrote:
Reproduced on my laptop with GOMAXPROCS=4.

Fix is https://codereview.appspot.com/7109043

On Tue, Jan 15, 2013 at 1:16 AM, Albert Strasheim wrote:

Hello

On Tue, Jan 15, 2013 at 3:02 AM, Brad Fitzpatrick <bradfitz@golang.org>
wrote:

This CL changed nothing about concurrency.
It did, however, change chunking. But the tests were adjusted.
Is this a sporadic failure? How to reproduce? I have machines with
over 10
cores.

Xeon E5-2670 0 @ 2.60GHz, performance governor, F16 64-bit kernel 3.3.8.

Test always passes with GOMAXPROCS=1 and fails about 80% of the time
with GOMAXPROCS=2 or greater.

Here's a few runs:

$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:27
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=1 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking
--- PASS: TestServerBufferedChunking (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:40
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:41
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- FAIL: TestServerBufferedChunking-2 (0.00 seconds)
serve_test.go:1165: response didn't end with a single 3 byte 'xyz'
chunk; got:
"HTTP/1.1 200 OK\r\nContent-Type: text/plain;
charset=utf-8\r\nDate: Tue, 15 Jan 2013 09:12:43
GMT\r\nTransfer-Encoding: chunked\r\n\r\n"
FAIL
$ GOMAXPROCS=2 ./http.test -test.v -test.run=TestServerBufferedChunking
=== RUN TestServerBufferedChunking-2
--- PASS: TestServerBufferedChunking-2 (0.00 seconds)
PASS

Regards

Albert

reply | permalink

Brad Fitzpatrick

at Jan 15, 2013 at 3:09 pm

⇧

Btw, we really should have at least one GOMAXPROCS >1 builder on the
dashboard. But thanks again for being our dashboard in the meantime and
finding all these.

On Mon, Jan 14, 2013 at 12:30 AM, wrote:

Howdy

There seems to be something wrong according to the torture box:

FAIL: TestServerBufferedChunking-10 at serve_test.go:1165

response didn't end with a single 3 byte 'xyz' chunk; got: "HTTP/1.1 200
OK\r\nContent-Type: text/plain; charset=utf-8\r\nDate: Mon, 14 Jan 2013
08:24:10 GMT\r\nTransfer-Encoding: chunked\r\n\r\n"

Looks a bit like this stuff from a while ago, but maybe that's just a
coincidence.

http://code.google.com/p/go/**issues/detail?id=4021<http://code.google.com/p/go/issues/detail?id=4021>

Cheers

Albert

https://codereview.appspot.**com/6964043/<https://codereview.appspot.com/6964043/>

reply | permalink

Dave Cheney

at Jan 15, 2013 at 7:19 pm

⇧

I set my Darwin builders to GOMAXPROCS=4 yesterday.

On 16/01/2013, at 2:09, Brad Fitzpatrick wrote:

Btw, we really should have at least one GOMAXPROCS >1 builder on the dashboard. But thanks again for being our dashboard in the meantime and finding all these.

On Mon, Jan 14, 2013 at 12:30 AM, wrote:
Howdy

There seems to be something wrong according to the torture box:

FAIL: TestServerBufferedChunking-10 at serve_test.go:1165

response didn't end with a single 3 byte 'xyz' chunk; got: "HTTP/1.1 200
OK\r\nContent-Type: text/plain; charset=utf-8\r\nDate: Mon, 14 Jan 2013
08:24:10 GMT\r\nTransfer-Encoding: chunked\r\n\r\n"

Looks a bit like this stuff from a while ago, but maybe that's just a
coincidence.

http://code.google.com/p/go/issues/detail?id=4021

Cheers

Albert

https://codereview.appspot.com/6964043/

reply | permalink

group	golang-dev @
categories	go
posted	Jan 14, '13 at 8:30a
active	Jan 15, '13 at 8:03p
posts	10
users	3
website	golang.org

responses	expanded	Hotkey: s
font	variable	Hotkey: f
user style	avatars	Hotkey: a

[golang-dev] Re: code review 6964043: net/http: buffer before chunking (issue 6964043)

Search Discussions

Related Discussions

3 users in discussion