FAQ
Can this wait until after 6996044 "dumbify the storage interface" gets
resolved? That would change what Jar.SetCookies looks like.

I know that 6996044 is still waiting for my response; I've been busy
with other things since coming back from vacation.

Finally, there's a typo in the change description: s/defaul/default/.


https://codereview.appspot.com/7069054/diff/7001/src/pkg/exp/cookiejar/jar.go
File src/pkg/exp/cookiejar/jar.go (right):

https://codereview.appspot.com/7069054/diff/7001/src/pkg/exp/cookiejar/jar.go#newcode96
src/pkg/exp/cookiejar/jar.go:96: cookie.Path = defPath
I'm not sure if SetCookies should modify the cookies passed to it.

https://codereview.appspot.com/7069054/

Search Discussions

  • Volker Dobler at Jan 9, 2013 at 4:09 pm

    On Wed, Jan 9, 2013 at 12:25 PM, wrote:

    Can this wait until after 6996044 "dumbify the storage interface" gets
    resolved? That would change what Jar.SetCookies looks like.
    Sure.

    src/pkg/exp/cookiejar/jar.go:**96: cookie.Path = defPath
    I'm not sure if SetCookies should modify the cookies passed to it.
    Actually this is a TODO in http's cookie handling:
    http://golang.org/src/pkg/net/http/cookie.go?s=2884:2910#L120
    but I don't think it should be fixed there as http.Cookie is
    more the "cookie on the wire" and not so much a jar'ed cookie.
    The path parsing could be fixed in readSetCookie but the
    domain parsing TODO 25 lines above not.

    V.
  • Volker Dobler at Jan 10, 2013 at 4:25 pm
    I composed a rough overview of the Cookiejar/Storage
    design goals, proposed APIs, my personal impression,
    some suggestions and still open question in the document

    https://docs.google.com/document/d/1w8VHqIGBmud9huUQ_nBNqOSqufqoxuSs93ZrXVvut_Q/edit

    Maybe it will be easier and quicker to discuss the upcoming
    API in this form than several CLs and counter CLs.

    Any comments welcome.

    V.


    On Wed, Jan 9, 2013 at 12:25 PM, wrote:

    Can this wait until after 6996044 "dumbify the storage interface" gets
    resolved? That would change what Jar.SetCookies looks like.

    I know that 6996044 is still waiting for my response; I've been busy
    with other things since coming back from vacation.

    Finally, there's a typo in the change description: s/defaul/default/.


    https://codereview.appspot.**com/7069054/diff/7001/src/pkg/**
    exp/cookiejar/jar.go<https://codereview.appspot.com/7069054/diff/7001/src/pkg/exp/cookiejar/jar.go>
    File src/pkg/exp/cookiejar/jar.go (right):

    https://codereview.appspot.**com/7069054/diff/7001/src/pkg/**
    exp/cookiejar/jar.go#newcode96<https://codereview.appspot.com/7069054/diff/7001/src/pkg/exp/cookiejar/jar.go#newcode96>
    src/pkg/exp/cookiejar/jar.go:**96: cookie.Path = defPath
    I'm not sure if SetCookies should modify the cookies passed to it.

    https://codereview.appspot.**com/7069054/<https://codereview.appspot.com/7069054/>


    --
    Dr. Volker Dobler

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 9, '13 at 11:31a
activeJan 10, '13 at 4:25p
posts3
users2
websitegolang.org

2 users in discussion

Volker Dobler: 2 posts Nigeltao: 1 post

People

Translate

site design / logo © 2022 Grokbase