FAQ
LGTM

Please make the CL description say cmd/5g, cmd/6g, cmd/8g.
The shorthands like *g or {5,6,8}g are more difficult to find with
hg log -k.

Also s/Flush/flush/.

FWIW, the bug is not that they are not spilled 'eagerly enough', it's
that they're
not flushed back at all in the case where the value appears to be dead.

https://codereview.appspot.com/7040044/

Search Discussions

  • Daniel Morsing at Jan 4, 2013 at 4:08 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=be6ca9f6bfe8 ***

    cmd/5g, cmd/6g, cmd/8g: flush return parameters in case of panic.

    Fixes issue 4066.

    R=rsc, minux.ma
    CC=golang-dev
    https://codereview.appspot.com/7040044


    https://codereview.appspot.com/7040044/
  • Daniel Morsing at Jan 4, 2013 at 4:21 pm

    On 2013/01/04 15:28:44, rsc wrote:
    FWIW, the bug is not that they are not spilled 'eagerly enough', it's that
    they're
    not flushed back at all in the case where the value appears to be
    dead.

    I think eagerly works in this case. The bug would also trigger on:

    func foo() (n int) {
    defer func() { _ = recover() }()
    n = 10
    panicingfunc()
    n = 20
    }

    However we describe it, the important part is that the bug is gone :)

    https://codereview.appspot.com/7040044/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 4, '13 at 3:28p
activeJan 4, '13 at 4:21p
posts3
users2
websitegolang.org

2 users in discussion

Daniel Morsing: 2 posts Rsc: 1 post

People

Translate

site design / logo © 2022 Grokbase