FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: speter.go1@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
doc: fix id attributes in links to godoc

CL6449105 changed godoc id attributes to ensure uniqueness.
This CL updates links to godoc pages in documents that used
the old id attributes.

Please review this at https://codereview.appspot.com/7015051/

Affected files:
M doc/articles/godoc_documenting_go_code.html
M doc/go1.html


Index: doc/articles/godoc_documenting_go_code.html
===================================================================
--- a/doc/articles/godoc_documenting_go_code.html
+++ b/doc/articles/godoc_documenting_go_code.html
@@ -83,7 +83,7 @@
the word <code>"BUG(who)"</code> are recognized as known bugs, and
included in
the "Bugs" section of the package documentation. The "who" part should be
the
user name of someone who could provide more information. For example, this
is a
-known issue from the <a href="/pkg/bytes/#bugs"><code>bytes</code></a>
package:
+known issue from the <a href="/pkg/bytes/#pkg-bugs"><code>bytes</code></a>
package:
</p>

<pre>
Index: doc/go1.html
===================================================================
--- a/doc/go1.html
+++ b/doc/go1.html
@@ -1676,7 +1676,7 @@
The <code>WalkFunc</code> function will be called even for files or
directories that could not be opened;
in such cases the error argument will describe the failure.
If a directory's contents are to be skipped,
-the function should return the value <a
href="/pkg/path/filepath/#variables"><code>filepath.SkipDir</code></a>
+the function should return the value <a
href="/pkg/path/filepath/#pkg-variables"><code>filepath.SkipDir</code></a>
</p>

{{code "/doc/progs/go1.go" `/STARTWALK/` `/ENDWALK/`}}
@@ -1865,7 +1865,7 @@
The imports will be updated by fix tool.
Single-template uses will be otherwise be largely unaffected.
Code that uses multiple templates in concert will need to be updated by
hand.
-The <a href="/pkg/text/template/#examples">examples</a> in
+The <a href="/pkg/text/template/#pkg-examples">examples</a> in
the documentation for <code>text/template</code> can provide guidance.
</p>

Search Discussions

  • Dsymonds at Dec 28, 2012 at 11:41 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=5cf37c9db688 ***

    doc: fix id attributes in links to godoc

    CL6449105 changed godoc id attributes to ensure uniqueness.
    This CL updates links to godoc pages in documents that used
    the old id attributes.

    R=golang-dev, dsymonds
    CC=golang-dev, speter.go1
    https://codereview.appspot.com/7015051

    Committer: David Symonds <dsymonds@golang.org>


    https://codereview.appspot.com/7015051/
  • David Symonds at Dec 29, 2012 at 1:34 am
    LGTM

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 28, '12 at 3:52p
activeDec 29, '12 at 1:34a
posts3
users2
websitegolang.org

2 users in discussion

David Symonds: 2 posts Speter Go1: 1 post

People

Translate

site design / logo © 2022 Grokbase