Reviewers: adonovan,
Message:
Hello adonovan@google.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go
Description:
go/types: moved from exp/types
This is a just a file move with no other changes
besides the manual import path adjustments in these
two files:
src/pkg/exp/gotype/gotype.go
src/pkg/exp/gotype/gotype_test.go
Please review this at https://codereview.appspot.com/7013049/
Affected files:
M src/pkg/exp/gotype/gotype.go
M src/pkg/exp/gotype/gotype_test.go
M src/pkg/go/types/api.go
M src/pkg/go/types/builtins.go
M src/pkg/go/types/check.go
M src/pkg/go/types/check_test.go
M src/pkg/go/types/const.go
M src/pkg/go/types/conversions.go
M src/pkg/go/types/errors.go
M src/pkg/go/types/exportdata.go
M src/pkg/go/types/expr.go
M src/pkg/go/types/gcimporter.go
M src/pkg/go/types/gcimporter_test.go
M src/pkg/go/types/operand.go
M src/pkg/go/types/predicates.go
M src/pkg/go/types/resolver_test.go
M src/pkg/go/types/stmt.go
M src/pkg/go/types/testdata/builtins.src
M src/pkg/go/types/testdata/const0.src
M src/pkg/go/types/testdata/conversions.src
M src/pkg/go/types/testdata/decls0.src
M src/pkg/go/types/testdata/decls1.src
M src/pkg/go/types/testdata/decls2a.src
M src/pkg/go/types/testdata/decls2b.src
M src/pkg/go/types/testdata/decls3.src
M src/pkg/go/types/testdata/exports.go
M src/pkg/go/types/testdata/expr0.src
M src/pkg/go/types/testdata/expr1.src
M src/pkg/go/types/testdata/expr2.src
M src/pkg/go/types/testdata/expr3.src
M src/pkg/go/types/testdata/stmt0.src
M src/pkg/go/types/types.go
M src/pkg/go/types/types_test.go
M src/pkg/go/types/universe.go
Index: src/pkg/exp/gotype/gotype.go
===================================================================
--- a/src/pkg/exp/gotype/gotype.go
+++ b/src/pkg/exp/gotype/gotype.go
@@ -6,13 +6,13 @@
import (
"errors"
- "exp/types"
"flag"
"fmt"
"go/ast"
"go/parser"
"go/scanner"
"go/token"
+ "go/types"
"io/ioutil"
"os"
"path/filepath"
Index: src/pkg/exp/gotype/gotype_test.go
===================================================================
--- a/src/pkg/exp/gotype/gotype_test.go
+++ b/src/pkg/exp/gotype/gotype_test.go
@@ -117,7 +117,6 @@
"flag",
"fmt",
- "exp/types",
"exp/gotype",
"go/ast",
@@ -128,6 +127,7 @@
"go/printer",
"go/scanner",
// "go/token",
+ "go/types",
"hash/adler32",
"hash/crc32",
Index: src/pkg/go/types/api.go
===================================================================
rename from src/pkg/exp/types/api.go
rename to src/pkg/go/types/api.go
Index: src/pkg/go/types/builtins.go
===================================================================
rename from src/pkg/exp/types/builtins.go
rename to src/pkg/go/types/builtins.go
Index: src/pkg/go/types/check.go
===================================================================
rename from src/pkg/exp/types/check.go
rename to src/pkg/go/types/check.go
Index: src/pkg/go/types/check_test.go
===================================================================
rename from src/pkg/exp/types/check_test.go
rename to src/pkg/go/types/check_test.go
Index: src/pkg/go/types/const.go
===================================================================
rename from src/pkg/exp/types/const.go
rename to src/pkg/go/types/const.go
Index: src/pkg/go/types/conversions.go
===================================================================
rename from src/pkg/exp/types/conversions.go
rename to src/pkg/go/types/conversions.go
Index: src/pkg/go/types/errors.go
===================================================================
rename from src/pkg/exp/types/errors.go
rename to src/pkg/go/types/errors.go
Index: src/pkg/go/types/exportdata.go
===================================================================
rename from src/pkg/exp/types/exportdata.go
rename to src/pkg/go/types/exportdata.go
Index: src/pkg/go/types/expr.go
===================================================================
rename from src/pkg/exp/types/expr.go
rename to src/pkg/go/types/expr.go
Index: src/pkg/go/types/gcimporter.go
===================================================================
rename from src/pkg/exp/types/gcimporter.go
rename to src/pkg/go/types/gcimporter.go
Index: src/pkg/go/types/gcimporter_test.go
===================================================================
rename from src/pkg/exp/types/gcimporter_test.go
rename to src/pkg/go/types/gcimporter_test.go
Index: src/pkg/go/types/operand.go
===================================================================
rename from src/pkg/exp/types/operand.go
rename to src/pkg/go/types/operand.go
Index: src/pkg/go/types/predicates.go
===================================================================
rename from src/pkg/exp/types/predicates.go
rename to src/pkg/go/types/predicates.go
Index: src/pkg/go/types/resolver_test.go
===================================================================
rename from src/pkg/exp/types/resolver_test.go
rename to src/pkg/go/types/resolver_test.go
Index: src/pkg/go/types/stmt.go
===================================================================
rename from src/pkg/exp/types/stmt.go
rename to src/pkg/go/types/stmt.go
Index: src/pkg/go/types/testdata/builtins.src
===================================================================
rename from src/pkg/exp/types/testdata/builtins.src
rename to src/pkg/go/types/testdata/builtins.src
Index: src/pkg/go/types/testdata/const0.src
===================================================================
rename from src/pkg/exp/types/testdata/const0.src
rename to src/pkg/go/types/testdata/const0.src
Index: src/pkg/go/types/testdata/conversions.src
===================================================================
rename from src/pkg/exp/types/testdata/conversions.src
rename to src/pkg/go/types/testdata/conversions.src
Index: src/pkg/go/types/testdata/decls0.src
===================================================================
rename from src/pkg/exp/types/testdata/decls0.src
rename to src/pkg/go/types/testdata/decls0.src
Index: src/pkg/go/types/testdata/decls1.src
===================================================================
rename from src/pkg/exp/types/testdata/decls1.src
rename to src/pkg/go/types/testdata/decls1.src
Index: src/pkg/go/types/testdata/decls2a.src
===================================================================
rename from src/pkg/exp/types/testdata/decls2a.src
rename to src/pkg/go/types/testdata/decls2a.src
Index: src/pkg/go/types/testdata/decls2b.src
===================================================================
rename from src/pkg/exp/types/testdata/decls2b.src
rename to src/pkg/go/types/testdata/decls2b.src
Index: src/pkg/go/types/testdata/decls3.src
===================================================================
rename from src/pkg/exp/types/testdata/decls3.src
rename to src/pkg/go/types/testdata/decls3.src
Index: src/pkg/go/types/testdata/exports.go
===================================================================
rename from src/pkg/exp/types/testdata/exports.go
rename to src/pkg/go/types/testdata/exports.go
Index: src/pkg/go/types/testdata/expr0.src
===================================================================
rename from src/pkg/exp/types/testdata/expr0.src
rename to src/pkg/go/types/testdata/expr0.src
Index: src/pkg/go/types/testdata/expr1.src
===================================================================
rename from src/pkg/exp/types/testdata/expr1.src
rename to src/pkg/go/types/testdata/expr1.src
Index: src/pkg/go/types/testdata/expr2.src
===================================================================
rename from src/pkg/exp/types/testdata/expr2.src
rename to src/pkg/go/types/testdata/expr2.src
Index: src/pkg/go/types/testdata/expr3.src
===================================================================
rename from src/pkg/exp/types/testdata/expr3.src
rename to src/pkg/go/types/testdata/expr3.src
Index: src/pkg/go/types/testdata/stmt0.src
===================================================================
rename from src/pkg/exp/types/testdata/stmt0.src
rename to src/pkg/go/types/testdata/stmt0.src
Index: src/pkg/go/types/types.go
===================================================================
rename from src/pkg/exp/types/types.go
rename to src/pkg/go/types/types.go
Index: src/pkg/go/types/types_test.go
===================================================================
rename from src/pkg/exp/types/types_test.go
rename to src/pkg/go/types/types_test.go
Index: src/pkg/go/types/universe.go
===================================================================
rename from src/pkg/exp/types/universe.go
rename to src/pkg/go/types/universe.go