FAQ
Reviewers: mikio, jsing, dho,

Message:
Hello mikioh.mikioh@gmail.com, jsing@google.com, devon.odell@gmail.com
(cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
net: consolidate fd_{free,net,open}bsd.go into fd_bsd.go

These files are identical, so probably pre date // +build.

With a little work, fd_darwin could be merged as well.

Please review this at https://codereview.appspot.com/7004053/

Affected files:
M src/pkg/net/fd_bsd.go
R src/pkg/net/fd_netbsd.go
R src/pkg/net/fd_openbsd.go

Search Discussions

  • Dave at Dec 23, 2012 at 3:57 am
    % sha1sum fd_{free,net,open}bsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_freebsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_netbsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_openbsd.go


    https://codereview.appspot.com/7004053/
  • Lucio De Re at Dec 23, 2012 at 6:20 am
    On 12/23/12, dave@cheney.net wrote:
    % sha1sum fd_{free,net,open}bsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_freebsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_netbsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_openbsd.go


    https://codereview.appspot.com/7004053/
  • Lucio De Re at Dec 23, 2012 at 6:20 am
    Oops, I'm sorry! (and compounding the mischief!)

    Lucio.

    On 12/23/12, Lucio De Re wrote:
    On 12/23/12, dave@cheney.net wrote:
    % sha1sum fd_{free,net,open}bsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_freebsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_netbsd.go
    9f2665109c567f1c91ef0f141b98558e77451deb fd_openbsd.go


    https://codereview.appspot.com/7004053/
  • Mikioh Mikioh at Dec 26, 2012 at 3:16 am
  • Dave at Dec 27, 2012 at 9:59 am

    On 2012/12/26 03:16:10, mikio wrote:
    LGTM
    Thanks. Anyone from the netbsd/openbsd camps have any objections ?

    https://codereview.appspot.com/7004053/
  • Minux Ma at Dec 27, 2012 at 1:18 pm
  • Jsing at Dec 27, 2012 at 1:24 pm
    LGTM

    I do not believe that they will diverge any time soon and if they do we
    can always split them out again.

    https://codereview.appspot.com/7004053/
  • Dave Cheney at Dec 27, 2012 at 1:27 pm
    Thanks folks, will look at committing this tomorrow, then I'll see if the
    Darwin variant can be merged.
    On 28 Dec 2012 00:24, wrote:

    LGTM

    I do not believe that they will diverge any time soon and if they do we
    can always split them out again.

    https://codereview.appspot.**com/7004053/<https://codereview.appspot.com/7004053/>
  • Dave at Dec 28, 2012 at 10:02 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=6496931a5a26 ***

    net: consolidate fd_{free,net,open}bsd.go into fd_bsd.go

    These files are identical, so probably pre date // +build.

    With a little work, fd_darwin could be merged as well.

    R=mikioh.mikioh, jsing, devon.odell, lucio.dere, minux.ma
    CC=golang-dev
    https://codereview.appspot.com/7004053


    https://codereview.appspot.com/7004053/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 23, '12 at 3:57a
activeDec 28, '12 at 10:02a
posts10
users5
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase