FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
runtime/debug: document that Stack is deprecated

Fixes issue 4070.

Please review this at https://codereview.appspot.com/7004050/

Affected files:
M src/pkg/runtime/debug/stack.go


Index: src/pkg/runtime/debug/stack.go
===================================================================
--- a/src/pkg/runtime/debug/stack.go
+++ b/src/pkg/runtime/debug/stack.go
@@ -29,6 +29,8 @@
// For each routine, it includes the source line information and PC value,
// then attempts to discover, for Go functions, the calling function or
// method and the text of the line containing the invocation.
+//
+// This function is deprecated. Use package runtime's Stack instead.
func Stack() []byte {
return stack()
}

Search Discussions

  • Brad Fitzpatrick at Dec 22, 2012 at 10:22 pm
    LGTM
    On Sat, Dec 22, 2012 at 2:20 PM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go/


    Description:
    runtime/debug: document that Stack is deprecated

    Fixes issue 4070.

    Please review this at https://codereview.appspot.**com/7004050/<https://codereview.appspot.com/7004050/>

    Affected files:
    M src/pkg/runtime/debug/stack.go


    Index: src/pkg/runtime/debug/stack.go
    ==============================**==============================**=======
    --- a/src/pkg/runtime/debug/stack.**go
    +++ b/src/pkg/runtime/debug/stack.**go
    @@ -29,6 +29,8 @@
    // For each routine, it includes the source line information and PC value,
    // then attempts to discover, for Go functions, the calling function or
    // method and the text of the line containing the invocation.
    +//
    +// This function is deprecated. Use package runtime's Stack instead.
    func Stack() []byte {
    return stack()
    }

  • Rsc at Dec 22, 2012 at 10:24 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=80cf79e46452 ***

    runtime/debug: document that Stack is deprecated

    Fixes issue 4070.

    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/7004050


    https://codereview.appspot.com/7004050/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 22, '12 at 10:20p
activeDec 22, '12 at 10:24p
posts3
users2
websitegolang.org

2 users in discussion

Rsc: 2 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2022 Grokbase