FAQ
Reviewers: rsc, golang-dev_googlegroups.com,

Message:
Hello rsc@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net: change ListenUnixgram signature to return UnixConn instead of
UDPConn

This CL breaks Go 1 API compatibility but it doesn't matter because
previous ListenUnixgram doesn't work in any use cases, oops.

The public API change is:
-pkg net, func ListenUnixgram(string, *UnixAddr) (*UDPConn, error)
+pkg net, func ListenUnixgram(string, *UnixAddr) (*UnixConn, error)

Fixes issue 3875.

Please review this at https://codereview.appspot.com/6937059/

Affected files:
M src/pkg/net/protoconn_test.go
M src/pkg/net/unixsock_plan9.go
M src/pkg/net/unixsock_posix.go

Search Discussions

  • Dave at Dec 15, 2012 at 3:13 am
    I think the API breakage has to be documented in

    $GOROOT/api/except.txt


    https://codereview.appspot.com/6937059/
  • Mikio Hara at Dec 15, 2012 at 4:01 am

    On Sat, Dec 15, 2012 at 12:13 PM, wrote:

    I think the API breakage has to be documented in

    $GOROOT/api/except.txt
    nice catch.
  • Dave Cheney at Dec 15, 2012 at 4:24 am
    And would probably warrant a mention in the go1.1 release notes.
    On 15 Dec 2012 15:01, "Mikio Hara" wrote:
    On Sat, Dec 15, 2012 at 12:13 PM, wrote:

    I think the API breakage has to be documented in

    $GOROOT/api/except.txt
    nice catch.
  • Mikio Hara at Dec 15, 2012 at 4:27 am
    I'd prefer doing it later with other stuff, such as IPv6.
    On Sat, Dec 15, 2012 at 1:24 PM, Dave Cheney wrote:
    And would probably warrant a mention in the go1.1 release notes.
    On 15 Dec 2012 15:01, "Mikio Hara" wrote:
    On Sat, Dec 15, 2012 at 12:13 PM, wrote:

    I think the API breakage has to be documented in

    $GOROOT/api/except.txt
    nice catch.
  • Russ Cox at Dec 15, 2012 at 6:13 pm
    Please add a short note to doc/go1.1.html. This is small enough that
    we might forget otherwise. The exact text doesn't matter so much -
    we'll rewrite it later.
  • Russ Cox at Dec 15, 2012 at 6:13 pm
    LGTM
  • Mikioh Mikioh at Dec 15, 2012 at 4:00 am
    Hello rsc@golang.org, golang-dev@googlegroups.com, dave@cheney.net (cc:
    golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/6937059/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 15, '12 at 2:53a
activeDec 15, '12 at 6:13p
posts8
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase