[golang-dev] Re: code review 6903061: cmd/go: handle os signals (issue 6903061)

Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.


https://codereview.appspot.com/6903061/

https://codereview.appspot.com/6903061/diff/22002/src/cmd/go/signal.go
File src/cmd/go/signal.go (right):

https://codereview.appspot.com/6903061/diff/22002/src/cmd/go/signal.go#newcode28
src/cmd/go/signal.go:28: onceCloseInterrupted.Do(closeInterrupted)
go process is ignoring these signals, so, I think, we can get second
signal while we doing something else. We should be prepared.

https://codereview.appspot.com/6903061/

ignoredSignals is maybe not accurate. The go process doesn't ignore the
signals, in fact, it watches for them. The downstream go
test/run/whatever process doesn't ignore them either, it reacts to them.

Maybe s/ignored/interruptible/ then it is clearer that the func waiting
on the sig chan closes the interrupted chan and then it is done.


https://codereview.appspot.com/6903061/

Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.


https://codereview.appspot.com/6903061/

https://codereview.appspot.com/6903061/diff/29009/src/cmd/go/signal.go
File src/cmd/go/signal.go (right):

https://codereview.appspot.com/6903061/diff/29009/src/cmd/go/signal.go#newcode28
src/cmd/go/signal.go:28: onceCloseInterrupted.Do(closeInterrupted)
I'm sorry to harp on this. I don't think the sync.Once handler is adding
anything that

go func() {
<- sig
close(closeInterrupted)
}()

wouldn't do

https://codereview.appspot.com/6903061/

Sorry, I meant to write
go func() {
<- sig
close(interrupted)
}()

https://codereview.appspot.com/6903061/

Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.


https://codereview.appspot.com/6903061/

LGTM. All my manual tests pass.

Thank you for your persistence, this is going to be a really useful
feature.

https://codereview.appspot.com/6903061/

Thank you for your help. I will submit it tonight - give others chance
to comment.

Alex

https://codereview.appspot.com/6903061/

*** Submitted as
https://code.google.com/p/go/source/detail?r=ee5afd4b14b7 ***

cmd/go: handle os signals

Ignore signals during "go run" and wait for running child
process to exit. Stop executing further tests during "go test",
wait for running tests to exit and report error exit code.

Original CL 6351053 by dfc.

Fixes issue 3572.
Fixes issue 3581.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/6903061


https://codereview.appspot.com/6903061/