FAQ
LGTM, very nice, thank you. A few minor comments if you feel like
addressing them in this CL.


https://codereview.appspot.com/6873060/diff/12001/ssh/certs.go
File ssh/certs.go (right):

https://codereview.appspot.com/6873060/diff/12001/ssh/certs.go#newcode47
ssh/certs.go:47: // and ecdsa-sha2-nistp521-cert-v01@openssh.com.
Suggestion: Maybe the constants above should be exported, then we can
move this part of the comment to describe those directly.

https://codereview.appspot.com/6873060/diff/12001/ssh/keys.go
File ssh/keys.go (right):

https://codereview.appspot.com/6873060/diff/12001/ssh/keys.go#newcode124
ssh/keys.go:124: return key, in, ok
/s/return.*/return/

https://codereview.appspot.com/6873060/diff/12001/ssh/keys.go#newcode347
ssh/keys.go:347: panic("unexpected key type")
there are a lot of panics that all do the same thing. Is a label useful
here ?

https://codereview.appspot.com/6873060/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 13, '12 at 11:16a
activeDec 13, '12 at 10:04p
posts6
users2
websitegolang.org

2 users in discussion

Dave: 3 posts Jmpittman: 3 posts

People

Translate

site design / logo © 2021 Grokbase