FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
misc/dashboard: don't email about netbsd failures

Too flaky.

Please review this at https://codereview.appspot.com/6925056/

Affected files:
M misc/dashboard/app/build/notify.go


Index: misc/dashboard/app/build/notify.go
===================================================================
--- a/misc/dashboard/app/build/notify.go
+++ b/misc/dashboard/app/build/notify.go
@@ -21,6 +21,13 @@
domain = "build.golang.org"
)

+// failIgnore is a set of builders that we don't email about because
+// they're too flaky.
+var failIgnore = map[string]bool{
+ "netbsd-386-bsiegert": true,
+ "netbsd-amd64-bsiegert": true,
+}
+
// notifyOnFailure checks whether the supplied Commit or the subsequent
// Commit (if present) breaks the build for this builder.
// If either of those commits break the build an email notification is sent
@@ -112,6 +119,10 @@
// sendFailMail sends a mail notification that the build failed on the
// provided commit and builder.
func sendFailMail(c appengine.Context, com *Commit, builder string) {
+ if failIgnore[builder] {
+ return
+ }
+
// TODO(adg): handle packages

// get Result

Search Discussions

  • Brad Fitzpatrick at Dec 12, 2012 at 7:02 pm
    s/that/which/ probably (preemptive defensive response)
    On Wed, Dec 12, 2012 at 10:59 AM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    misc/dashboard: don't email about netbsd failures

    Too flaky.

    Please review this at https://codereview.appspot.**com/6925056/<https://codereview.appspot.com/6925056/>

    Affected files:
    M misc/dashboard/app/build/**notify.go


    Index: misc/dashboard/app/build/**notify.go
    ==============================**==============================**=======
    --- a/misc/dashboard/app/build/**notify.go
    +++ b/misc/dashboard/app/build/**notify.go
    @@ -21,6 +21,13 @@
    domain = "build.golang.org"
    )

    +// failIgnore is a set of builders that we don't email about because
    +// they're too flaky.
    +var failIgnore = map[string]bool{
    + "netbsd-386-bsiegert": true,
    + "netbsd-amd64-bsiegert": true,
    +}
    +
    // notifyOnFailure checks whether the supplied Commit or the subsequent
    // Commit (if present) breaks the build for this builder.
    // If either of those commits break the build an email notification is
    sent
    @@ -112,6 +119,10 @@
    // sendFailMail sends a mail notification that the build failed on the
    // provided commit and builder.
    func sendFailMail(c appengine.Context, com *Commit, builder string) {
    + if failIgnore[builder] {
    + return
    + }
    +
    // TODO(adg): handle packages

    // get Result

  • Iant at Dec 12, 2012 at 7:02 pm
  • Russ Cox at Dec 12, 2012 at 7:08 pm
    NOT LGTM
  • Brad Fitzpatrick at Dec 12, 2012 at 7:09 pm

    On Wed, Dec 12, 2012 at 11:08 AM, Russ Cox wrote:

    NOT LGTM
    so it _is_ "that"?
  • Rsc at Dec 12, 2012 at 7:10 pm
    https://codereview.appspot.com/6925056/diff/5001/misc/dashboard/app/build/notify.go
    File misc/dashboard/app/build/notify.go (right):

    https://codereview.appspot.com/6925056/diff/5001/misc/dashboard/app/build/notify.go#newcode40
    misc/dashboard/app/build/notify.go:40: // TODO(adg): implement
    notifications for packages
    The if statement and return need to be here.
    sendFailMail is only called (by this function) for the first broken
    builder in a grid row. With the if in sendFailMail, if the first broken
    builder is an ignored one, we will not get mail from actually broken
    builders that detect the failure later.

    https://codereview.appspot.com/6925056/
  • Bradfitz at Dec 12, 2012 at 7:14 pm
    Hello iant@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/6925056/
  • Rsc at Dec 12, 2012 at 7:29 pm
  • Bradfitz at Dec 12, 2012 at 7:33 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=8f2748bfb556 ***

    misc/dashboard: don't email about netbsd failures

    Too flaky.

    R=iant, rsc
    CC=golang-dev
    https://codereview.appspot.com/6925056


    https://codereview.appspot.com/6925056/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 12, '12 at 6:59p
activeDec 12, '12 at 7:33p
posts9
users3
websitegolang.org

3 users in discussion

Bradfitz: 5 posts Rsc: 3 posts Iant: 1 post

People

Translate

site design / logo © 2022 Grokbase