FAQ
LGTM

I didn't read the implementation very carefully. If you and Volker
agree, I'm happy.



https://codereview.appspot.com/6912045/diff/6003/publicsuffix/list.go
File publicsuffix/list.go (right):

https://codereview.appspot.com/6912045/diff/6003/publicsuffix/list.go#newcode18
publicsuffix/list.go:18: // List implements cookiejar.PublicSuffixList.
// List implements cookiejar.PublicSuffixList using a copy of the
publicsuffix.org
// database compiled into the library.

https://codereview.appspot.com/6912045/

Search Discussions

  • Nigeltao at Dec 12, 2012 at 4:59 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=73ed64aa79d2&repo=net ***

    go.net/publicsuffix: new package.

    The tables were generated by:

    go run gen.go -subset -version "subset of publicsuffix.org's
    effective_tld_names.dat, hg revision 05b11a8d1ace (2012-11-09)"
    table.go
    go run gen.go -subset -version "subset of publicsuffix.org's
    effective_tld_names.dat, hg revision 05b11a8d1ace (2012-11-09)" -test
    table_test.go
    The input data is subsetted so that code review is easier while still
    covering the interesting * and ! rules. A follow-up changelist will
    check in the unfiltered public suffix list.

    Update issue 1960.

    R=rsc, dr.volker.dobler
    CC=golang-dev
    https://codereview.appspot.com/6912045


    https://codereview.appspot.com/6912045/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 12, '12 at 4:02a
activeDec 12, '12 at 4:59a
posts2
users2
websitegolang.org

2 users in discussion

Nigeltao: 1 post Rsc: 1 post

People

Translate

site design / logo © 2022 Grokbase