[golang-dev] Re: code review 6900055: goauth2: Use content-type detection to select codec (issue 6900055)

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go
File oauth/oauth.go (right):

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go#newcode296
oauth/oauth.go:296: content :=
strings.Split(r.Header.Get("Content-Type"), ";")
content := strings.Split(r.Header.Get("Content-Type"), ";")[0]

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go#newcode297
oauth/oauth.go:297: switch content[0] {
switch content {

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go#newcode298
oauth/oauth.go:298: case "application/x-www-form-urlencoded",
"text/plain":
why text/plain?

https://codereview.appspot.com/6900055/

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go
File oauth/oauth.go (right):

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go#newcode254
oauth/oauth.go:254: req.Header.Set("Authorization", "Bearer
"+t.AccessToken)
Short answer: Yes.
Long answer: Yes, it is even the only header which is
a) in the official spec[1]
b) supported by all of Google, GitHub and Facebook's OAuth providers
[1]: http://tools.ietf.org/html/draft-ietf-oauth-v2-31#section-7.1

https://codereview.appspot.com/6900055/diff/5001/oauth/oauth.go#newcode298
oauth/oauth.go:298: case "application/x-www-form-urlencoded",
"text/plain":
“Be liberal in what you accept”, and more hilariously: Because Facebook
doesn't seem to set the `Content-Type` header appropriately. They return
urlencoded data with a `text/plain` content type. Defaulting to
urlencode when getting `text/plain` seems appropriate after browsing the
spec.

https://codereview.appspot.com/6900055/

Hello adg@google.com, adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.


http://codereview.appspot.com/6900055/