FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
encoding/xml: fix typo in Marshal documentation

Fixes issue 4512.

Please review this at https://codereview.appspot.com/6917043/

Affected files:
M src/pkg/encoding/xml/marshal.go


Index: src/pkg/encoding/xml/marshal.go
===================================================================
--- a/src/pkg/encoding/xml/marshal.go
+++ b/src/pkg/encoding/xml/marshal.go
@@ -45,7 +45,7 @@
// - a field with tag "name,attr" becomes an attribute with
// the given name in the XML element.
// - a field with tag ",attr" becomes an attribute with the
-// field name in the in the XML element.
+// field name in the XML element.
// - a field with tag ",chardata" is written as character data,
// not as an XML element.
// - a field with tag ",innerxml" is written verbatim, not subject

Search Discussions

  • Brad Fitzpatrick at Dec 10, 2012 at 3:58 pm
    LGTM
    On Mon, Dec 10, 2012 at 6:40 AM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    encoding/xml: fix typo in Marshal documentation

    Fixes issue 4512.

    Please review this at https://codereview.appspot.**com/6917043/<https://codereview.appspot.com/6917043/>

    Affected files:
    M src/pkg/encoding/xml/marshal.**go


    Index: src/pkg/encoding/xml/marshal.**go
    ==============================**==============================**=======
    --- a/src/pkg/encoding/xml/**marshal.go
    +++ b/src/pkg/encoding/xml/**marshal.go
    @@ -45,7 +45,7 @@
    // - a field with tag "name,attr" becomes an attribute with
    // the given name in the XML element.
    // - a field with tag ",attr" becomes an attribute with the
    -// field name in the in the XML element.
    +// field name in the XML element.
    // - a field with tag ",chardata" is written as character data,
    // not as an XML element.
    // - a field with tag ",innerxml" is written verbatim, not subject

  • Bradfitz at Dec 10, 2012 at 3:59 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=d3de4a6597bb ***

    encoding/xml: fix typo in Marshal documentation

    Fixes issue 4512.

    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/6917043

    Committer: Brad Fitzpatrick <bradfitz@golang.org>


    https://codereview.appspot.com/6917043/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 10, '12 at 11:41a
activeDec 10, '12 at 3:59p
posts3
users2
websitegolang.org

2 users in discussion

Bradfitz: 2 posts Franciscossouza: 1 post

People

Translate

site design / logo © 2022 Grokbase