FAQ
LGTM


https://codereview.appspot.com/6907045/diff/1/pkg/present/parse.go
File pkg/present/parse.go (right):

https://codereview.appspot.com/6907045/diff/1/pkg/present/parse.go#newcode230
pkg/present/parse.go:230: if mode&TitlesOnly > 0 {
s/>/!=/

is more canonical (w/ > I am tempted to figure out if there's more
meaning to it)

https://codereview.appspot.com/6907045/diff/1/pkg/present/parse.go#newcode373
pkg/present/parse.go:373: if doc.Subtitle == "" {
I would negate the condition and get rid of the continue:

if doc.Subtitle != "" {
return fmt.Errorf("unexpected header line: %q", text)
}
doc.Subtitle = text

https://codereview.appspot.com/6907045/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 7, '12 at 1:32a
activeDec 7, '12 at 2:48a
posts3
users2
websitegolang.org

2 users in discussion

Adg: 2 posts Gri: 1 post

People

Translate

site design / logo © 2021 Grokbase