FAQ
LGTM

Nice test.



https://codereview.appspot.com/6869053/diff/5001/src/pkg/net/http/client_test.go
File src/pkg/net/http/client_test.go (right):

https://codereview.appspot.com/6869053/diff/5001/src/pkg/net/http/client_test.go#newcode531
src/pkg/net/http/client_test.go:531: // Verify Resposne.ContentLength is
populated. http://golang.org/issue/4126
Response

https://codereview.appspot.com/6869053/diff/5001/src/pkg/net/http/transport.go
File src/pkg/net/http/transport.go (right):

https://codereview.appspot.com/6869053/diff/5001/src/pkg/net/http/transport.go#newcode607
src/pkg/net/http/transport.go:607: hasBody := resp != nil &&
(rc.req.Method != "HEAD" && resp.ContentLength != 0)
() are weird; did you mean || inside instead of && ?
drop them if the expression is correct.

https://codereview.appspot.com/6869053/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 6, '12 at 4:54a
activeDec 6, '12 at 6:36a
posts2
users2
websitegolang.org

2 users in discussion

Rsc: 1 post Bradfitz: 1 post

People

Translate

site design / logo © 2022 Grokbase