FAQ
Reviewers: rsc, iant, r, ken2,

Message:
Hello rsc@golang.org, iant@golang.org, r@golang.org, ken@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
spec: BuiltinCall syntax must permit "..." for append

Also: fix an incorrect link.

Fixes issue 4479.
Fixes issue 4456.

Please review this at https://codereview.appspot.com/6868062/

Affected files:
M doc/go_spec.html


Index: doc/go_spec.html
===================================================================
--- a/doc/go_spec.html
+++ b/doc/go_spec.html
@@ -1,6 +1,6 @@
<!--{
"Title": "The Go Programming Language Specification",
- "Subtitle": "Version of December 3, 2012",
+ "Subtitle": "Version of December 4, 2012",
"Path": "/ref/spec"
}-->

@@ -1013,7 +1013,7 @@
A field declaration may be followed by an optional string literal
<i>tag</i>,
which becomes an attribute for all the fields in the corresponding
field declaration. The tags are made
-visible through a <a href="#Package_unsafe">reflection interface</a>
+visible through a <a href="/pkg/reflect/#StructTag">reflection
interface</a>
but are otherwise ignored.
</p>

@@ -4831,7 +4831,7 @@

<pre class="ebnf">
BuiltinCall = identifier "(" [ BuiltinArgs [ "," ] ] ")" .
-BuiltinArgs = Type [ "," ExpressionList ] | ExpressionList .
+BuiltinArgs = Type [ "," ArgumentList ] | ArgumentList .
</pre>

<h3 id="Close">Close</h3>

Search Discussions

  • Gri at Dec 4, 2012 at 9:09 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=644271a17661 ***

    spec: BuiltinCall syntax must permit "..." for append

    Also: fix an incorrect link.

    Fixes issue 4479.
    Fixes issue 4456.

    R=rsc, iant, r, ken
    CC=golang-dev
    https://codereview.appspot.com/6868062


    https://codereview.appspot.com/6868062/
  • Ian Lance Taylor at Dec 4, 2012 at 9:14 pm
    LGTM
    On Tue, Dec 4, 2012 at 12:42 PM, wrote:
    Reviewers: rsc, iant, r, ken2,

    Message:
    Hello rsc@golang.org, iant@golang.org, r@golang.org, ken@golang.org (cc:
    golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    spec: BuiltinCall syntax must permit "..." for append

    Also: fix an incorrect link.

    Fixes issue 4479.
    Fixes issue 4456.

    Please review this at https://codereview.appspot.com/6868062/

    Affected files:
    M doc/go_spec.html


    Index: doc/go_spec.html
    ===================================================================
    --- a/doc/go_spec.html
    +++ b/doc/go_spec.html
    @@ -1,6 +1,6 @@
    <!--{
    "Title": "The Go Programming Language Specification",
    - "Subtitle": "Version of December 3, 2012",
    + "Subtitle": "Version of December 4, 2012",
    "Path": "/ref/spec"
    }-->

    @@ -1013,7 +1013,7 @@
    A field declaration may be followed by an optional string literal
    <i>tag</i>,
    which becomes an attribute for all the fields in the corresponding
    field declaration. The tags are made
    -visible through a <a href="#Package_unsafe">reflection interface</a>
    +visible through a <a href="/pkg/reflect/#StructTag">reflection
    interface</a>
    but are otherwise ignored.
    </p>

    @@ -4831,7 +4831,7 @@

    <pre class="ebnf">
    BuiltinCall = identifier "(" [ BuiltinArgs [ "," ] ] ")" .
    -BuiltinArgs = Type [ "," ExpressionList ] | ExpressionList .
    +BuiltinArgs = Type [ "," ArgumentList ] | ArgumentList .
    </pre>

    <h3 id="Close">Close</h3>

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 4, '12 at 8:42p
activeDec 4, '12 at 9:14p
posts3
users2
websitegolang.org

2 users in discussion

Gri: 2 posts Ian Lance Taylor: 1 post

People

Translate

site design / logo © 2022 Grokbase