[golang-dev] code review 6875044: net: simplify ListenTCP (issue 6875044)

On Sun, Dec 2, 2012 at 8:27 PM, wrote:

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net: simplify ListenTCP

Please review this at https://codereview.appspot.**com/6875044/<https://codereview.appspot.com/6875044/>

Affected files:
M src/pkg/net/tcpsock_posix.go


Index: src/pkg/net/tcpsock_posix.go
==============================**==============================**=======
--- a/src/pkg/net/tcpsock_posix.go
+++ b/src/pkg/net/tcpsock_posix.go
@@ -299,7 +299,5 @@
closesocket(fd.sysfd)
return nil, &OpError{"listen", net, laddr, err}
}
- l := new(TCPListener)
- l.fd = fd
- return l, nil
+ return &TCPListener{fd}, nil
}

LGTM with the minor change in the case that TCPListener grows another
private field in the future.