FAQ
thank you for tackling this.


https://codereview.appspot.com/6782140/diff/6001/src/pkg/log/syslog/syslog.go
File src/pkg/log/syslog/syslog.go (right):

https://codereview.appspot.com/6782140/diff/6001/src/pkg/log/syslog/syslog.go#newcode1
src/pkg/log/syslog/syslog.go:1: // Copyright 2012 The Go Authors. All
rights reserved.
no need to update copyright line.

https://codereview.appspot.com/6782140/diff/6001/src/pkg/log/syslog/syslog.go#newcode18
src/pkg/log/syslog/syslog.go:18: "syscall"
well, please have a look at src/pkg/go/build/deps_test.go.
also please run all.bash before review.

// pkgDeps defines the expected dependencies between packages in
// the Go source tree. It is a statement of policy.
// Changes should not be made to this map without prior discussion.
//
// The map contains two kinds of entries:
// 1) Lower-case keys are standard import paths and list the
// allowed imports in that package.
// 2) Upper-case keys define aliases for package sets, which can then
// be used as dependencies by other rules.
//
// DO NOT CHANGE THIS DATA TO FIX BUILDS.

https://codereview.appspot.com/6782140/diff/6001/src/pkg/log/syslog/syslog.go#newcode122
src/pkg/log/syslog/syslog.go:122: if w.conn != nil {
no lock?

https://codereview.appspot.com/6782140/diff/6001/src/pkg/log/syslog/syslog.go#newcode147
src/pkg/log/syslog/syslog.go:147: return oe.Err == syscall.ECONNREFUSED
platform independent?

https://codereview.appspot.com/6782140/

Search Discussions

  • Jeff Allen at Dec 1, 2012 at 8:18 pm
    OK, I think I understand the problem. log/syslog is allowed to use L4,
    OS and net. So it seems like I should be checking something in os or net
    instead of syscall. So it seems like I will need to add the concept of
    conn refused in net, following the pattern of Timeout(), perhaps. Sound
    like the right general direction to go?

    https://codereview.appspot.com/6782140/
  • Mikio Hara at Dec 2, 2012 at 5:26 am

    On Sun, Dec 2, 2012 at 5:18 AM, wrote:

    OK, I think I understand the problem. log/syslog is allowed to use L4,
    OS and net. So it seems like I should be checking something in os or net
    instead of syscall.
    The standard library has been organized well to prevent circular
    dependency issues. I didn't say we cannot use syscall, just need
    a discussion in another thread, not in a CL review.
    So it seems like I will need to add the concept of
    conn refused in net, following the pattern of Timeout(), perhaps.
    Sound like the right general direction to go?
    It depends on underlying connections. For example, you never
    note that the far end of socket has been closed when you are
    using "udp" or "unixgram" even if the socket has been configured
    as designated 5-tuple by syscall connect because of the nature of
    datagram protocols.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 1, '12 at 1:16p
activeDec 2, '12 at 5:26a
posts3
users2
websitegolang.org

2 users in discussion

Mikio Hara: 2 posts Jeff Allen: 1 post

People

Translate

site design / logo © 2022 Grokbase