FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
os: check only user attributes in TestStatDirModeExec

Some have their system setup in a particular way,
see http://golang.org/issue/4444#c3.

Please review this at https://codereview.appspot.com/6851129/

Affected files:
M src/pkg/os/os_test.go


Index: src/pkg/os/os_test.go
===================================================================
--- a/src/pkg/os/os_test.go
+++ b/src/pkg/os/os_test.go
@@ -1097,13 +1097,13 @@
}

func TestStatDirModeExec(t *testing.T) {
- const mode = 0111
+ const mode = 0100
const path = "."
dir, err := Stat(path)
if err != nil {
t.Fatalf("Stat %q (looking for mode %#o): %s", path, mode, err)
}
if dir.Mode()&mode != mode {
- t.Errorf("Stat %q: mode %#o want %#o", path, dir.Mode(), mode)
+ t.Errorf("Stat %q: mode %#o want %#o", path, dir.Mode()&mode, mode)
}
}

Search Discussions

  • Brad Fitzpatrick at Nov 30, 2012 at 3:32 am
    Russ had wanted all bits tested in the previous CL comments, right? You
    could make a tempdir with that mode, defer os.RemoveAll(tempDir), then,
    stat the tempdir?
    On Thu, Nov 29, 2012 at 7:20 PM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    os: check only user attributes in TestStatDirModeExec

    Some have their system setup in a particular way,
    see http://golang.org/issue/4444#**c3 <http://golang.org/issue/4444#c3>.

    Please review this at https://codereview.appspot.**com/6851129/<https://codereview.appspot.com/6851129/>

    Affected files:
    M src/pkg/os/os_test.go


    Index: src/pkg/os/os_test.go
    ==============================**==============================**=======
    --- a/src/pkg/os/os_test.go
    +++ b/src/pkg/os/os_test.go
    @@ -1097,13 +1097,13 @@
    }

    func TestStatDirModeExec(t *testing.T) {
    - const mode = 0111
    + const mode = 0100
    const path = "."
    dir, err := Stat(path)
    if err != nil {
    t.Fatalf("Stat %q (looking for mode %#o): %s", path, mode,
    err)
    }
    if dir.Mode()&mode != mode {
    - t.Errorf("Stat %q: mode %#o want %#o", path, dir.Mode(),
    mode)
    + t.Errorf("Stat %q: mode %#o want %#o", path,
    dir.Mode()&mode, mode)
    }
    }

  • Alex Brainman at Nov 30, 2012 at 4:12 am
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/6851129/
  • Bradfitz at Nov 30, 2012 at 5:05 am
  • Alex Brainman at Nov 30, 2012 at 5:10 am
    Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
    golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/6851129/
  • Alex Brainman at Nov 30, 2012 at 5:10 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=c15545810dcd ***

    os: check only user attributes in TestStatDirModeExec

    Some have their system setup in a particular way,
    see http://golang.org/issue/4444#c3.

    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/6851129


    https://codereview.appspot.com/6851129/
  • Alex Brainman at Nov 30, 2012 at 5:11 am

    On 2012/11/30 05:10:21, brainman wrote:
    Hello mailto:golang-dev@googlegroups.com, mailto:bradfitz@golang.org (cc:
    mailto:golang-dev@googlegroups.com),
    Please take another look.
    Please, ignore. Wrong button. It is beer time.

    Alex

    https://codereview.appspot.com/6851129/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 30, '12 at 3:20a
activeNov 30, '12 at 5:11a
posts7
users2
websitegolang.org

2 users in discussion

Alex Brainman: 5 posts Bradfitz: 2 posts

People

Translate

site design / logo © 2022 Grokbase