FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
http/transport.go: trivial comment error.

Please review this at http://codereview.appspot.com/6856078/

Affected files:
M src/pkg/net/http/transport.go


Index: src/pkg/net/http/transport.go
===================================================================
--- a/src/pkg/net/http/transport.go
+++ b/src/pkg/net/http/transport.go
@@ -71,7 +71,7 @@
DisableCompression bool

// MaxIdleConnsPerHost, if non-zero, controls the maximum idle
- // (keep-alive) to keep to keep per-host. If zero,
+ // (keep-alive) to keep per-host. If zero,
// DefaultMaxIdleConnsPerHost is used.
MaxIdleConnsPerHost int
}

Search Discussions

  • Brad Fitzpatrick at Nov 24, 2012 at 2:17 am
    LGTM
    On Fri, Nov 23, 2012 at 9:53 AM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    http/transport.go: trivial comment error.

    Please review this at http://codereview.appspot.com/**6856078/<http://codereview.appspot.com/6856078/>

    Affected files:
    M src/pkg/net/http/transport.go


    Index: src/pkg/net/http/transport.go
    ==============================**==============================**=======
    --- a/src/pkg/net/http/transport.**go
    +++ b/src/pkg/net/http/transport.**go
    @@ -71,7 +71,7 @@
    DisableCompression bool

    // MaxIdleConnsPerHost, if non-zero, controls the maximum idle
    - // (keep-alive) to keep to keep per-host. If zero,
    + // (keep-alive) to keep per-host. If zero,
    // DefaultMaxIdleConnsPerHost is used.
    MaxIdleConnsPerHost int
    }

  • Caine Tighe at Nov 24, 2012 at 9:00 pm
    Can you submit this? I want a clean 'hg p' before I submit the keep-alive
    tunables and pipelining.

    On Friday, November 23, 2012 9:17:00 PM UTC-5, Brad Fitzpatrick wrote:

    LGTM

    On Fri, Nov 23, 2012 at 9:53 AM, <arctanof...@gmail.com <javascript:>>wrote:
    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golan...@googlegroups.com <javascript:> (cc:
    golan...@googlegroups.com <javascript:>),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    http/transport.go: trivial comment error.

    Please review this at http://codereview.appspot.com/**6856078/<http://codereview.appspot.com/6856078/>

    Affected files:
    M src/pkg/net/http/transport.go


    Index: src/pkg/net/http/transport.go
    ==============================**==============================**=======
    --- a/src/pkg/net/http/transport.**go
    +++ b/src/pkg/net/http/transport.**go
    @@ -71,7 +71,7 @@
    DisableCompression bool

    // MaxIdleConnsPerHost, if non-zero, controls the maximum idle
    - // (keep-alive) to keep to keep per-host. If zero,
    + // (keep-alive) to keep per-host. If zero,
    // DefaultMaxIdleConnsPerHost is used.
    MaxIdleConnsPerHost int
    }

  • Minux Ma at Nov 24, 2012 at 9:08 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=a17f2ff31447 ***

    http/transport.go: trivial comment error.

    R=golang-dev, bradfitz
    CC=golang-dev
    http://codereview.appspot.com/6856078

    Committer: Shenghou Ma <minux.ma@gmail.com>


    http://codereview.appspot.com/6856078/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 23, '12 at 5:53p
activeNov 24, '12 at 9:08p
posts4
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase