FAQ
Please move os/user/lookup stuff to its own CL.
Looks very close, thank you.


https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/iprawsock_plan9.go
File src/pkg/net/iprawsock_plan9.go (right):

https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/iprawsock_plan9.go#newcode17
src/pkg/net/iprawsock_plan9.go:17: type IPConn struct{}
type IPConn struct {
conn
}

Then you can drop placeholders for Conn, from Read to Close.

https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/net.go
File src/pkg/net/net.go (right):

https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/net.go#newcode368
src/pkg/net/net.go:368: type writerOnly struct {
I'd prefer these stuff stay in tcpsock.go.

https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/unixsock_plan9.go
File src/pkg/net/unixsock_plan9.go (right):

https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/unixsock_plan9.go#newcode17
src/pkg/net/unixsock_plan9.go:17: type UnixConn struct{}
type UnixConn struct {
conn
}

Then you can drop placeholders for Conn, from Read to Close.

https://codereview.appspot.com/6674043/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 23, '12 at 5:10a
activeNov 23, '12 at 5:10a
posts1
users1
websitegolang.org

1 user in discussion

Mikioh Mikioh: 1 post

People

Translate

site design / logo © 2022 Grokbase