[golang-dev] Re: code review 6846081: net/http: fix TestChunkReaderAllocs failure when GOMAXP... (issue 6846081)

LGTM, but wait for fullung to confirm.


https://codereview.appspot.com/6846081/

LGTM

https://codereview.appspot.com/6846081/

Reviewers: albert.strasheim, bradfitz,

Message:
Hello fullung@gmail.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net/http: fix TestChunkReaderAllocs failure when GOMAXPROCS > 1

Please review this at http://codereview.appspot.com/6846081/

Affected files:
    M src/pkg/net/http/chunked_test.go


Index: src/pkg/net/http/chunked_test.go
===================================================================
--- a/src/pkg/net/http/chunked_test.go
+++ b/src/pkg/net/http/chunked_test.go
@@ -42,6 +42,8 @@
   }

   func TestChunkReaderAllocs(t *testing.T) {
+ // temporarily set GOMAXPROCS to 1 as we are testing memory allocations
+ defer runtime.GOMAXPROCS(runtime.GOMAXPROCS(1))
    var buf bytes.Buffer
    w := newChunkedWriter(&buf)
    a, b, c := []byte("aaaaaa"), []byte("bbbbbbbbbbbb"),
[]byte("cccccccccccccccccccccccc")

Needs to be done in both copies. http and httputil.

Really, we should drop one of the test copies.

Do you have suggestions?

LGTM

Deleting a test file and z-ifying one of the impls can come layer.

Thanks for the fix.

*** Submitted as
http://code.google.com/p/go/source/detail?r=1315abc581ed ***

net/http, net/http/httputil: fix TestChunkReaderAllocs failure when
GOMAXPROCS > 1

R=fullung, bradfitz, dave
CC=golang-dev
http://codereview.appspot.com/6846081


http://codereview.appspot.com/6846081/

ok net 2.969s
--- FAIL: TestChunkReaderAllocs (0.03 seconds)
         chunked_test.go:67: 14 mallocs; want <= 1
FAIL
FAIL net/http 6.938s

Please comment on this issue, https://code.google.com/p/go/issues/detail?id=5608