FAQ
Hello fullung@gmail.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.


http://codereview.appspot.com/6846081/

Search Discussions

  • Dave at Nov 20, 2012 at 9:53 am
    LGTM, but wait for fullung to confirm.


    https://codereview.appspot.com/6846081/
  • Fullung at Nov 20, 2012 at 10:01 am
  • Minux Ma at Nov 20, 2012 at 10:17 am
    Reviewers: albert.strasheim, bradfitz,

    Message:
    Hello fullung@gmail.com, bradfitz@golang.org (cc:
    golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    net/http: fix TestChunkReaderAllocs failure when GOMAXPROCS > 1

    Please review this at http://codereview.appspot.com/6846081/

    Affected files:
        M src/pkg/net/http/chunked_test.go


    Index: src/pkg/net/http/chunked_test.go
    ===================================================================
    --- a/src/pkg/net/http/chunked_test.go
    +++ b/src/pkg/net/http/chunked_test.go
    @@ -42,6 +42,8 @@
       }

       func TestChunkReaderAllocs(t *testing.T) {
    + // temporarily set GOMAXPROCS to 1 as we are testing memory allocations
    + defer runtime.GOMAXPROCS(runtime.GOMAXPROCS(1))
        var buf bytes.Buffer
        w := newChunkedWriter(&buf)
        a, b, c := []byte("aaaaaa"), []byte("bbbbbbbbbbbb"),
    []byte("cccccccccccccccccccccccc")
  • Brad Fitzpatrick at Nov 20, 2012 at 3:32 pm
    Needs to be done in both copies. http and httputil.

    Really, we should drop one of the test copies.
    On Nov 20, 2012 1:50 AM, wrote:

    Reviewers: albert.strasheim, bradfitz,

    Message:
    Hello fullung@gmail.com, bradfitz@golang.org (cc:
    golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    net/http: fix TestChunkReaderAllocs failure when GOMAXPROCS > 1

    Please review this at http://codereview.appspot.com/**6846081/<http://codereview.appspot.com/6846081/>

    Affected files:
    M src/pkg/net/http/chunked_test.**go


    Index: src/pkg/net/http/chunked_test.**go
    ==============================**==============================**=======
    --- a/src/pkg/net/http/chunked_**test.go
    +++ b/src/pkg/net/http/chunked_**test.go
    @@ -42,6 +42,8 @@
    }

    func TestChunkReaderAllocs(t *testing.T) {
    + // temporarily set GOMAXPROCS to 1 as we are testing memory
    allocations
    + defer runtime.GOMAXPROCS(runtime.**GOMAXPROCS(1))
    var buf bytes.Buffer
    w := newChunkedWriter(&buf)
    a, b, c := []byte("aaaaaa"), []byte("bbbbbbbbbbbb"), []byte("**
    cccccccccccccccccccccccc")

  • Minux at Nov 20, 2012 at 4:04 pm

    On Tue, Nov 20, 2012 at 11:16 PM, Brad Fitzpatrick wrote:

    Needs to be done in both copies. http and httputil.
    Already done in Patch Set 3.
    Really, we should drop one of the test copies.
    Do you have suggestions?
  • Brad Fitzpatrick at Nov 20, 2012 at 3:27 pm
    LGTM

    Deleting a test file and z-ifying one of the impls can come layer.

    Thanks for the fix.
      On Nov 20, 2012 7:20 AM, "minux" wrote:

    On Tue, Nov 20, 2012 at 11:16 PM, Brad Fitzpatrick wrote:

    Needs to be done in both copies. http and httputil.
    Already done in Patch Set 3.
    Really, we should drop one of the test copies.
    Do you have suggestions?
  • Minux Ma at Nov 20, 2012 at 6:24 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=1315abc581ed ***

    net/http, net/http/httputil: fix TestChunkReaderAllocs failure when
    GOMAXPROCS > 1

    R=fullung, bradfitz, dave
    CC=golang-dev
    http://codereview.appspot.com/6846081


    http://codereview.appspot.com/6846081/
  • Tegoor at Aug 1, 2013 at 6:41 am
    ok net 2.969s
    --- FAIL: TestChunkReaderAllocs (0.03 seconds)
             chunked_test.go:67: 14 mallocs; want <= 1
    FAIL
    FAIL net/http 6.938s
    On Wednesday, November 21, 2012 2:18:52 AM UTC+8, minux wrote:

    *** Submitted as
    http://code.google.com/p/go/source/detail?r=1315abc581ed ***

    net/http, net/http/httputil: fix TestChunkReaderAllocs failure when
    GOMAXPROCS > 1

    R=fullung, bradfitz, dave
    CC=golang-dev
    http://codereview.appspot.com/6846081


    http://codereview.appspot.com/6846081/
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave Cheney at Jul 31, 2013 at 11:57 pm
    Please comment on this issue, https://code.google.com/p/go/issues/detail?id=5608

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 20, '12 at 9:52a
activeAug 1, '13 at 6:41a
posts10
users5
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase