|
Dave |
at Nov 22, 2012 at 1:11 pm
|
⇧ |
| |
Thank you for this proposal, some comments attached.
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.goFile src/pkg/net/timeout_test.go (right):
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode21src/pkg/net/timeout_test.go:21: ln, err := Listen("tcp", "127.0.0.1:0")
Why not just ListenTCP(...), then you don't need the type assertion ?
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode24src/pkg/net/timeout_test.go:24: }
defer ln.Close()
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode27src/pkg/net/timeout_test.go:27: if _, err := ln.Accept();
!err.(Error).Timeout() {
This will panic if err is not a *net.Error. I guess that is the point,
but the t.Fatalf will not be reached if this isn't the expected type.
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode65src/pkg/net/timeout_test.go:65: ln, err := Listen("tcp", "127.0.0.1:0")
ListenTCP(...)
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode70src/pkg/net/timeout_test.go:70: c, err := Dial("tcp",
ln.Addr().String())
DialTCP("tcp", nil, ln.Addr())
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode73src/pkg/net/timeout_test.go:73: }
defer c.Close()
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode116src/pkg/net/timeout_test.go:116: ln, err := Listen("tcp", "127.0.0.1:0")
Same as above
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode124src/pkg/net/timeout_test.go:124: }
defer c.Close()
https://codereview.appspot.com/6850070/