FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
debug/elf: fix offset for GNU version symbols

Since we no longer skip the first entry when reading a symbol table,
we no longer need to allow for the offset difference when processing
the GNU version symbols.

Unbreaks builds on Linux.

Please review this at http://codereview.appspot.com/6843057/

Affected files:
M src/pkg/debug/elf/file.go


Index: src/pkg/debug/elf/file.go
===================================================================
--- a/src/pkg/debug/elf/file.go
+++ b/src/pkg/debug/elf/file.go
@@ -700,8 +700,8 @@
// gnuVersion adds Library and Version information to sym,
// which came from offset i of the symbol table.
func (f *File) gnuVersion(i int, sym *ImportedSymbol) {
- // Each entry is two bytes; skip undef entry at beginning.
- i = (i + 1) * 2
+ // Each entry is two bytes.
+ i = i * 2
if i >= len(f.gnuVersym) {
return
}

Search Discussions

  • Agl at Nov 14, 2012 at 4:27 pm
    LGTM if it unbreaks the build.

    https://codereview.appspot.com/6843057/
  • Ian Lance Taylor at Nov 14, 2012 at 4:37 pm
    LGTM
    On Wed, Nov 14, 2012 at 8:20 AM, wrote:
    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    debug/elf: fix offset for GNU version symbols

    Since we no longer skip the first entry when reading a symbol table,
    we no longer need to allow for the offset difference when processing
    the GNU version symbols.

    Unbreaks builds on Linux.

    Please review this at http://codereview.appspot.com/6843057/

    Affected files:
    M src/pkg/debug/elf/file.go


    Index: src/pkg/debug/elf/file.go
    ===================================================================
    --- a/src/pkg/debug/elf/file.go
    +++ b/src/pkg/debug/elf/file.go
    @@ -700,8 +700,8 @@
    // gnuVersion adds Library and Version information to sym,
    // which came from offset i of the symbol table.
    func (f *File) gnuVersion(i int, sym *ImportedSymbol) {
    - // Each entry is two bytes; skip undef entry at beginning.
    - i = (i + 1) * 2
    + // Each entry is two bytes.
    + i = i * 2
    if i >= len(f.gnuVersym) {
    return
    }
  • Jsing at Nov 14, 2012 at 4:39 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=76ff7da868c6 ***

    debug/elf: fix offset for GNU version symbols

    Since we no longer skip the first entry when reading a symbol table,
    we no longer need to allow for the offset difference when processing
    the GNU version symbols.

    Unbreaks builds on Linux.

    R=golang-dev, agl, iant
    CC=golang-dev
    http://codereview.appspot.com/6843057


    http://codereview.appspot.com/6843057/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 14, '12 at 4:20p
activeNov 14, '12 at 4:39p
posts4
users3
websitegolang.org

3 users in discussion

Jsing: 2 posts Ian Lance Taylor: 1 post Agl: 1 post

People

Translate

site design / logo © 2022 Grokbase