[golang-dev] code review 6843057: debug/elf: fix offset for GNU version symbols (issue 6843057)

On Wed, Nov 14, 2012 at 8:20 AM, wrote:
Reviewers: golang-dev_googlegroups.com,

Message:
Hello [email protected],

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
debug/elf: fix offset for GNU version symbols

Since we no longer skip the first entry when reading a symbol table,
we no longer need to allow for the offset difference when processing
the GNU version symbols.

Unbreaks builds on Linux.

Please review this at http://codereview.appspot.com/6843057/

Affected files:
M src/pkg/debug/elf/file.go


Index: src/pkg/debug/elf/file.go
===================================================================
--- a/src/pkg/debug/elf/file.go
+++ b/src/pkg/debug/elf/file.go
@@ -700,8 +700,8 @@
// gnuVersion adds Library and Version information to sym,
// which came from offset i of the symbol table.
func (f *File) gnuVersion(i int, sym *ImportedSymbol) {
- // Each entry is two bytes; skip undef entry at beginning.
- i = (i + 1) * 2
+ // Each entry is two bytes.
+ i = i * 2
if i >= len(f.gnuVersym) {
return
}