FAQ
Reviewers: albert.strasheim,

Message:
Hello fullung@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
run.bash: unset GOMAXPROCS before ../test

test/run.go already executes tests in parallel where
possible. An unknown GOMAXPROCS value during the tests
is known to cause failures with tests that measure
allocations.

ref:
https://groups.google.com/d/topic/golang-nuts/tgMhFJ3F5WY/discussion

Please review this at http://codereview.appspot.com/6847050/

Affected files:
M src/run.bash


Index: src/run.bash
===================================================================
--- a/src/run.bash
+++ b/src/run.bash
@@ -115,6 +115,7 @@
go test ../test/bench/go1

(xcd ../test
+unset GOMAXPROCS
time go run run.go
) || exit $?

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 14, '12 at 10:19a
activeNov 15, '12 at 12:41a
posts10
users4
websitegolang.org

4 users in discussion

Dave: 5 posts Minux: 2 posts Fullung: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase