FAQ

On 2012/11/13 16:46:32, iant2 wrote:
On Tue, Nov 13, 2012 at 7:15 AM, Joel Sing
wrote:
On 14 November 2012 01:33, Ian Lance Taylor
wrote:
This is going to change the behaviour of the Symbols function in
debug/elf and potentially break any current users. I don't know if
that is a good idea. Certainly any change would need to be
documented
in doc/go1.1.html.
Indeed. As I've noted in the issue, there are two obvious fixes -
stop
skipping the first symbol, or adjust the symbol index in the
relocation code. While the second of these avoids a change in
existing
behaviour, I think the first option is more "correct" since we
expose
the ELF and DWARF data. Anyone using these packages is currently
expected to know that an index into the symbol table needs to be
adjusted to account for the fact that debug/elf is discarding the
first symbol.
Makes sense to me. Can you please add a change to go1.1.html to this
CL? Thanks.
Done. PTAL.

https://codereview.appspot.com/6848044/

Search Discussions

  • Iant at Nov 14, 2012 at 2:19 pm
    LGTM with one change.


    https://codereview.appspot.com/6848044/diff/10001/doc/go1.1.html
    File doc/go1.1.html (right):

    https://codereview.appspot.com/6848044/diff/10001/doc/go1.1.html#newcode71
    doc/go1.1.html:71: processes the symbol table returned from debug/elf
    may need to be adjusted to
    s|processes the symbol table returned from debug/elf|calls the debug/elf
    functions Symbols or ImportedSymbols|

    https://codereview.appspot.com/6848044/
  • Jsing at Nov 14, 2012 at 3:22 pm

    On 2012/11/14 14:19:36, iant wrote:
    LGTM with one change.
    https://codereview.appspot.com/6848044/diff/10001/doc/go1.1.html
    File doc/go1.1.html (right):

    https://codereview.appspot.com/6848044/diff/10001/doc/go1.1.html#newcode71
    doc/go1.1.html:71: processes the symbol table returned from debug/elf may need
    to be adjusted to
    s|processes the symbol table returned from debug/elf|calls the debug/elf
    functions Symbols or ImportedSymbols|
    Done.

    https://codereview.appspot.com/6848044/
  • Jsing at Nov 14, 2012 at 3:27 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=9ea9e7e6e0c8 ***

    debug/elf: do not skip first symbol in the symbol table

    Do not skip the first symbol in the symbol table. Any other indexes
    into the symbol table (for example, indexes in relocation entries)
    will now refer to the symbol following the one that was intended.

    Add an object that contains debug relocations, which debug/dwarf
    failed to decode correctly. Extend the relocation tests to cover
    this case.

    Note that the existing tests passed since the symbol following the
    symbol that required relocation is also of type STT_SECTION.

    Fixes issue 4107.

    R=golang-dev, mikioh.mikioh, iant, iant
    CC=golang-dev
    http://codereview.appspot.com/6848044


    http://codereview.appspot.com/6848044/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 14, '12 at 10:35a
activeNov 14, '12 at 3:27p
posts4
users2
websitegolang.org

2 users in discussion

Jsing: 3 posts Iant: 1 post

People

Translate

site design / logo © 2022 Grokbase