FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
runtime: re-enable crash test on FreeBSD

It also passes on FreeBSD.

Please review this at http://codereview.appspot.com/6812103/

Affected files:
M src/pkg/runtime/crash_test.go


Index: src/pkg/runtime/crash_test.go
===================================================================
--- a/src/pkg/runtime/crash_test.go
+++ b/src/pkg/runtime/crash_test.go
@@ -9,7 +9,6 @@
"os"
"os/exec"
"path/filepath"
- "runtime"
"testing"
"text/template"
)
@@ -22,12 +21,6 @@
// both main (m0) and non-main threads (m).

func testCrashHandler(t *testing.T, ct *crashTest) {
- if runtime.GOOS == "freebsd" {
- // TODO(brainman): do not know why this test fails on freebsd
- t.Logf("skipping test on %q", runtime.GOOS)
- return
- }
-
st := template.Must(template.New("crashSource").Parse(crashSource))

dir, err := ioutil.TempDir("", "go-build")

Search Discussions

  • Brad Fitzpatrick at Nov 9, 2012 at 12:56 am
    LGTM
    On Thu, Nov 8, 2012 at 6:47 PM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    runtime: re-enable crash test on FreeBSD

    It also passes on FreeBSD.

    Please review this at http://codereview.appspot.com/**6812103/<http://codereview.appspot.com/6812103/>

    Affected files:
    M src/pkg/runtime/crash_test.go


    Index: src/pkg/runtime/crash_test.go
    ==============================**==============================**=======
    --- a/src/pkg/runtime/crash_test.**go
    +++ b/src/pkg/runtime/crash_test.**go
    @@ -9,7 +9,6 @@
    "os"
    "os/exec"
    "path/filepath"
    - "runtime"
    "testing"
    "text/template"
    )
    @@ -22,12 +21,6 @@
    // both main (m0) and non-main threads (m).

    func testCrashHandler(t *testing.T, ct *crashTest) {
    - if runtime.GOOS == "freebsd" {
    - // TODO(brainman): do not know why this test fails on
    freebsd
    - t.Logf("skipping test on %q", runtime.GOOS)
    - return
    - }
    -
    st := template.Must(template.New("**crashSource").Parse(**
    crashSource))

    dir, err := ioutil.TempDir("", "go-build")

  • Mikioh Mikioh at Nov 9, 2012 at 1:07 am
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=581daad1f33e ***

    runtime: re-enable crash test on FreeBSD

    It also passes on FreeBSD.

    R=golang-dev, bradfitz
    CC=golang-dev
    http://codereview.appspot.com/6812103


    http://codereview.appspot.com/6812103/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 9, '12 at 12:47a
activeNov 9, '12 at 1:07a
posts3
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 2 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2022 Grokbase