FAQ

On 2012/11/08 14:27:59, dvyukov wrote:
Hello mailto:golang-dev@googlegroups.com,
I'd like you to review this change to
https://dvyukov%2540google.com%40code.google.com/p/go/
I've added here necessary runtime changes and the README file.
The runtime is built on revision 167609.


https://codereview.appspot.com/6810095/

Search Discussions

  • Minux Ma at Nov 9, 2012 at 11:29 am
    please update the description.


    https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README
    File src/pkg/runtime/race/README (right):

    https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README#newcode10
    src/pkg/runtime/race/README:10: You may need gcc >= 4.6.1. gcc 4.3
    produces bad syso files with weak symbols
    is this still the case? CL 6783050 just modified cmd/ld to support weak
    symbols.
    sorry i don't have gcc 4.3 to test.
    if it's still true, could you please mail me a copy of bad linux/amd64
    syso off
    list so that i can fix the issue in cmd/6l?

    https://codereview.appspot.com/6810095/
  • Dvyukov at Nov 9, 2012 at 11:31 am

    On 2012/11/09 11:29:28, minux wrote:
    please update the description.
    Done.


    https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README
    File src/pkg/runtime/race/README (right):

    https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README#newcode10
    src/pkg/runtime/race/README:10: You may need gcc >= 4.6.1. gcc 4.3
    produces bad
    syso files with weak symbols
    is this still the case? CL 6783050 just modified cmd/ld to support
    weak symbols.
    sorry i don't have gcc 4.3 to test.
    if it's still true, could you please mail me a copy of bad linux/amd64 syso off
    list so that i can fix the issue in cmd/6l?
    I will try to reproduce it.



    https://codereview.appspot.com/6810095/
  • Dvyukov at Nov 9, 2012 at 11:43 am

    On 2012/11/09 11:31:55, dvyukov wrote:
    On 2012/11/09 11:29:28, minux wrote:
    please update the description.
    Done.
    > >
    https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README
    File src/pkg/runtime/race/README (right):
    https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README#newcode10
    src/pkg/runtime/race/README:10: You may need gcc >= 4.6.1. gcc 4.3
    produces
    bad
    syso files with weak symbols
    is this still the case? CL 6783050 just modified cmd/ld to support
    weak
    symbols.
    sorry i don't have gcc 4.3 to test.
    if it's still true, could you please mail me a copy of bad
    linux/amd64 syso
    off
    list so that i can fix the issue in cmd/6l?
    I will try to reproduce it.
    Seem to work now.

    However gcc 4.4 still fails when I build in debug mode:

    gotsan.cc:1485: sorry, unimplemented: inlining failed in call to ‘void
    __tsan::MemoryAccessImpl(__tsan::ThreadState*, __sanitizer::uptr, int,
    bool, __tsan::FastState, __sanitizer::u64*, __tsan::Shadow)’: function
    not inlinable

    I rephrased it as "Tested with gcc 4.6.1 and 4.7.0."


    https://codereview.appspot.com/6810095/
  • Minux at Nov 11, 2012 at 5:49 pm

    On Fri, Nov 9, 2012 at 7:43 PM, wrote:
    Seem to work now.
    good to hear.
    However gcc 4.4 still fails when I build in debug mode:

    gotsan.cc:1485: sorry, unimplemented: inlining failed in call to ‘void
    __tsan::MemoryAccessImpl(__**tsan::ThreadState*, __sanitizer::uptr, int,
    bool, __tsan::FastState, __sanitizer::u64*, __tsan::Shadow)’: function
    not inlinable

    I rephrased it as "Tested with gcc 4.6.1 and 4.7.0.“
    the README looks fine to me now.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 9, '12 at 11:24a
activeNov 11, '12 at 5:49p
posts5
users2
websitegolang.org

2 users in discussion

Dvyukov: 3 posts Minux: 2 posts

People

Translate

site design / logo © 2022 Grokbase