FAQ

On 2012/11/08 18:21:36, mikio wrote:
Hello mailto:rsc@golang.org, mailto:ality@pbrane.org (cc:
mailto:golang-dev@googlegroups.com),
Please take another look.
Hi,

I appreciate the sentiment of this change, but I'm not sold on another
function call in the call stack for most operations. Apart from (minor)
performance concerns, I thought what we had worked well, and I worry
that this is a large change where a small fixup to missing comments
would do.

I think inside this CL there is a smaller CL trying to get out. For
example, the net_posix.go -> net.go change looks good.

Cheers

Dave

https://codereview.appspot.com/6814101/

Search Discussions

  • Mikio Hara at Nov 9, 2012 at 8:40 am

    On Fri, Nov 9, 2012 at 3:33 PM, wrote:

    I appreciate the sentiment of this change, but I'm not sold on another
    function call in the call stack for most operations.
    Thanks for your comments.
    Apart from (minor)
    performance concerns, I thought what we had worked well, and I worry
    that this is a large change where a small fixup to missing comments
    would do.
    I started to write this CL instead of a nightcap last night but it grew
    up as you see, why? anyway if you think splitting this CL makes
    sense, will do.
    I think inside this CL there is a smaller CL trying to get out. For
    example, the net_posix.go -> net.go change looks good.
    Seems you can admit tweaking Conn interface stuff on both POSIX
    and Plan 9, of course w/o thin wrapper functions, right?
  • Mikioh Mikioh at Nov 9, 2012 at 11:11 am

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 9, '12 at 6:33a
activeNov 9, '12 at 11:11a
posts3
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 2 posts Dave: 1 post

People

Translate

site design / logo © 2021 Grokbase