|| at Nov 8, 2012 at 6:17 pm
File src/pkg/net/ipsock_plan9.go (right):https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/ipsock_plan9.go#newcode311
src/pkg/net/ipsock_plan9.go:311: // Accept implements the Accept method
in the Listener interface; it waits
I'd remove everything from the semicolon on. Redundant.https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/ipsock_plan9.go#newcode328
src/pkg/net/ipsock_plan9.go:328: // Addr returns the listener's network
address, a *TCPAddr.
I'd write this as:
// Addr returns the listener's address.
// The address will be of type *TCPAddr.https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go
File src/pkg/net/tcpsock_plan9.go (right):https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go#newcode56
On 2012/11/08 04:34:43, ality wrote:
On 2012/11/08 03:54:48, dfc wrote:
Similarly, are these methods needed to satisfy an interface, if not,
sure adding them helps.
Again, these were added to appease cmd/api.
Are they required by the Go 1 api?
Yes, they are. go1.txt says:
pkg net, method (*TCPConn) SetLinger(int) error
... which means people can depend on that being available (compiling at
least) on all operating systems and architectures.https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go#newcode97
src/pkg/net/tcpsock_plan9.go:97: // Close stops listening on the TCP
address. Already Accepted connections
src/pkg/net/tcpsock_plan9.go:130: // AcceptTCP accepts the next incoming
call and returns the new connection
// AcceptTCP accepts the next incoming call.https://codereview.appspot.com/6674043/