FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/


Description:
runtime: fix instrumentation of slice append for race detection

Please review this at http://codereview.appspot.com/6819107/

Affected files:
M src/pkg/runtime/slice.c


Index: src/pkg/runtime/slice.c
===================================================================
--- a/src/pkg/runtime/slice.c
+++ b/src/pkg/runtime/slice.c
@@ -86,6 +86,8 @@
runtime·racereadpc(x.array + i*t->elem->size, pc);
for(i=x.len; i<x.cap; i++)
runtime·racewritepc(x.array + i*t->elem->size, pc);
+ for(i=0; i<y.len; i++)
+ runtime·racereadpc(y.array + i*t->elem->size, pc);
}

if(m > x.cap)

Search Discussions

  • Ian Lance Taylor at Nov 8, 2012 at 4:29 pm
    LGTM
    On Thu, Nov 8, 2012 at 6:08 AM, wrote:
    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://dvyukov%40google.com@code.google.com/p/go/


    Description:
    runtime: fix instrumentation of slice append for race detection

    Please review this at http://codereview.appspot.com/6819107/

    Affected files:
    M src/pkg/runtime/slice.c


    Index: src/pkg/runtime/slice.c
    ===================================================================
    --- a/src/pkg/runtime/slice.c
    +++ b/src/pkg/runtime/slice.c
    @@ -86,6 +86,8 @@
    runtime·racereadpc(x.array + i*t->elem->size, pc);
    for(i=x.len; i<x.cap; i++)
    runtime·racewritepc(x.array + i*t->elem->size, pc);
    + for(i=0; i<y.len; i++)
    + runtime·racereadpc(y.array + i*t->elem->size, pc);
    }

    if(m > x.cap)
  • Dvyukov at Nov 8, 2012 at 4:37 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=a91f2cb13436 ***

    runtime: fix instrumentation of slice append for race detection

    R=golang-dev, iant
    CC=golang-dev
    http://codereview.appspot.com/6819107


    http://codereview.appspot.com/6819107/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 8, '12 at 2:08p
activeNov 8, '12 at 4:37p
posts3
users2
websitegolang.org

2 users in discussion

Dvyukov: 2 posts Ian Lance Taylor: 1 post

People

Translate

site design / logo © 2022 Grokbase