FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
runtime: re-enable crash test on NetBSD

Re-enable the crash tests on NetBSD now that the issue has been
identified and fixed.

Please review this at http://codereview.appspot.com/6813100/

Affected files:
M src/pkg/runtime/crash_test.go


Index: src/pkg/runtime/crash_test.go
===================================================================
--- a/src/pkg/runtime/crash_test.go
+++ b/src/pkg/runtime/crash_test.go
@@ -22,10 +22,8 @@
// both main (m0) and non-main threads (m).

func testCrashHandler(t *testing.T, ct *crashTest) {
- if runtime.GOOS == "freebsd" || runtime.GOOS == "netbsd" {
+ if runtime.GOOS == "freebsd" {
// TODO(brainman): do not know why this test fails on freebsd
- // TODO(jsing): figure out why this causes delayed failures
- // on NetBSD - http://golang.org/issue/3954
t.Logf("skipping test on %q", runtime.GOOS)
return
}

Search Discussions

  • Brad Fitzpatrick at Nov 8, 2012 at 4:33 pm
    LGTM
    On Thu, Nov 8, 2012 at 10:31 AM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    runtime: re-enable crash test on NetBSD

    Re-enable the crash tests on NetBSD now that the issue has been
    identified and fixed.

    Please review this at http://codereview.appspot.com/**6813100/<http://codereview.appspot.com/6813100/>

    Affected files:
    M src/pkg/runtime/crash_test.go


    Index: src/pkg/runtime/crash_test.go
    ==============================**==============================**=======
    --- a/src/pkg/runtime/crash_test.**go
    +++ b/src/pkg/runtime/crash_test.**go
    @@ -22,10 +22,8 @@
    // both main (m0) and non-main threads (m).

    func testCrashHandler(t *testing.T, ct *crashTest) {
    - if runtime.GOOS == "freebsd" || runtime.GOOS == "netbsd" {
    + if runtime.GOOS == "freebsd" {
    // TODO(brainman): do not know why this test fails on
    freebsd
    - // TODO(jsing): figure out why this causes delayed failures
    - // on NetBSD - http://golang.org/issue/3954
    t.Logf("skipping test on %q", runtime.GOOS)
    return
    }

  • Jsing at Nov 8, 2012 at 4:43 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=8a55a33e2e85 ***

    runtime: re-enable crash test on NetBSD

    Re-enable the crash tests on NetBSD now that the issue has been
    identified and fixed.

    R=golang-dev, bradfitz
    CC=golang-dev
    http://codereview.appspot.com/6813100


    http://codereview.appspot.com/6813100/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 8, '12 at 4:31p
activeNov 8, '12 at 4:43p
posts3
users2
websitegolang.org

2 users in discussion

Jsing: 2 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2022 Grokbase